From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7515BFF8867 for ; Wed, 29 Apr 2026 06:21:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wHyI2-0004a5-Pj; Wed, 29 Apr 2026 02:20:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHyHe-0004S1-6g; Wed, 29 Apr 2026 02:20:40 -0400 Received: from out30-131.freemail.mail.aliyun.com ([115.124.30.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wHyHZ-00076R-5s; Wed, 29 Apr 2026 02:20:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1777443613; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=tlTY7ncAgdp+7jq8GZCOWdsv/CZJyqyfltIvrzhJHJo=; b=rTI8fwDN/v7KKveO+IGGJsb7S1aX988KFP7OdBAeliCBLB8tu+C19qhjKaU8kFO+6vfBOlxkbswwgq3sEnKD5ORKq4HG1PEKuXWg0IpWLF7jOL1YosvlCsQYouggrRBl9E9SLtRPX3Hmk1rULMcJfSqGsd7oD4uzWkDWKy/tNvQ= X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R151e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=maildocker-contentspam033037009110; MF=guobin@linux.alibaba.com; NM=1; PH=DS; RN=6; SR=0; TI=SMTPD_---0X1wRJUT_1777443605; Received: from localhost(mailfrom:guobin@linux.alibaba.com fp:SMTPD_---0X1wRJUT_1777443605 cluster:ay36) by smtp.aliyun-inc.com; Wed, 29 Apr 2026 14:20:12 +0800 From: Bin Guo To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, berrange@redhat.com, kwolf@redhat.com, hreitz@redhat.com, qemu-block@nongnu.org Subject: [PATCH 0/3] Minor cleanups: eliminate redundant code in QOM, block-backend and vl.c Date: Wed, 29 Apr 2026 14:20:01 +0800 Message-ID: <20260429062004.36582-1-guobin@linux.alibaba.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=115.124.30.131; envelope-from=guobin@linux.alibaba.com; helo=out30-131.freemail.mail.aliyun.com X-Spam_score_int: -174 X-Spam_score: -17.5 X-Spam_bar: ----------------- X-Spam_report: (-17.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org This series contains three independent cleanups that remove redundant code and improve consistency across different subsystems. Patch 1 merges a double hash-table traversal in object_property_del_child() into a single pass, halving the number of hash table operations in the common case. Patch 2 makes blk_co_preadv() a one-liner wrapper around blk_co_preadv_part(), matching the existing pattern already used by the write side (blk_co_pwritev / blk_co_pwritev_part). Patch 3 inlines qemu_opts_parse_noisily() return-value checks directly into if-conditions for options that do not use the returned pointer, matching the style already used by QEMU_OPTION_action. All three patches are independent and can be applied in any order. Bin Guo (3): qom/object: merge double hash table traversal in object_property_del_child block/block-backend: delegate blk_co_preadv to blk_co_preadv_part system/vl.c: inline qemu_opts_parse_noisily() result checks block/block-backend.c | 8 +------- qom/object.c | 7 ------- system/vl.c | 37 +++++++++++++++---------------------- 3 files changed, 16 insertions(+), 36 deletions(-) -- 2.50.1 (Apple Git-155)