From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6CB6CD4F35 for ; Tue, 12 May 2026 12:31:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wMmFn-0000Ov-Bd; Tue, 12 May 2026 08:30:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wMmFb-0000M6-8x for qemu-devel@nongnu.org; Tue, 12 May 2026 08:30:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wMmFV-00028k-DI for qemu-devel@nongnu.org; Tue, 12 May 2026 08:30:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778589007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RCKuVa9Th1VXE9STTLzp2UOr9cxHr2IO/1g8sYpXVCg=; b=ePOG9EMeYmkbmr5sW0yDJmkv2mleH0AQK72YCe7ll2/n8KEs/xr3SZRMgxNnwVMiPajpSO PqD4YS6WsiI+OifMnTrLrKst/zNRi86j6psxgH8ioL6t8kS+ElVijq8ayX1R8Q/sOGLcwy ZqvWZk6a3T14JpUhAJkeddql6ixKbzc= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-674-iIRrdHBwOhyWMTcFrksbRg-1; Tue, 12 May 2026 08:30:03 -0400 X-MC-Unique: iIRrdHBwOhyWMTcFrksbRg-1 X-Mimecast-MFC-AGG-ID: iIRrdHBwOhyWMTcFrksbRg_1778589002 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8E69718005BF; Tue, 12 May 2026 12:30:02 +0000 (UTC) Received: from berrange.com (unknown [10.44.49.244]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9FF4F30001BB; Tue, 12 May 2026 12:30:00 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 00/10] qom: misc cleanups / fixes Date: Tue, 12 May 2026 13:29:48 +0100 Message-ID: <20260512122958.788097-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org The overall theme of this patch is to move some logic out of object_interfaces.c into object.c, since it is not tied to the user creatable interface. Changed in v4: - Invoke va_end on the correct variable - Fix commit message typo Changed in v3: - Fix parent/child mixup in trace event param names - Make QDict const in new constructors Changed in v2: - Ensure object creation always triggers module loading - Remove redundant NULL check in trace event - Remove double #include line Daniel P. Berrangé (10): qom: add trace events for object/property lifecycle qom: validate ID format when creating objects qom: make errp last param in methods taking va_list qom: shorten name of object_set_properties_from_keyval qom: have object_set_props_keyval return bool qom: move object_set_prop_keyval into object.c qom: add object_new_with_props_from_qdict qom: fix ability to create objects without a parent qom: allow object_new_with_prop* to trigger module loading qom: drop user_creatable_add_type method authz/listfile.c | 4 +- include/qom/object.h | 121 ++++++++++++++--- include/qom/object_interfaces.h | 18 --- qom/object.c | 230 ++++++++++++++++++++++++++++---- qom/object_interfaces.c | 101 +------------- qom/trace-events | 12 +- system/qdev-monitor.c | 4 +- system/vl.c | 7 +- tests/unit/check-qom-proplist.c | 97 +++++++++++--- 9 files changed, 409 insertions(+), 185 deletions(-) -- 2.54.0