QEMU-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-block@nongnu.org, "Kevin Wolf" <kwolf@redhat.com>,
	"John Snow" <jsnow@redhat.com>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH v6 08/16] tests: add a meson suite / make target per block I/O tests format
Date: Wed, 13 May 2026 12:59:55 +0100	[thread overview]
Message-ID: <20260513120003.226790-9-berrange@redhat.com> (raw)
In-Reply-To: <20260513120003.226790-1-berrange@redhat.com>

Currently each block format is classified as either 'quick', 'slow' or
'thorough' and this controls whether its I/O tests are added to the meson
suites 'block-quick', 'block-slow' or 'block-thorough'.

This suites are exposed the 'check-block' make target, accepting the
optional SPEED variable.

As we add more formats to the 'thorough' group, however, it becomes
increasingly large and time consuming to run. What is needed is a make
target that can exercise all tests for an individual format, regardless
of speed classification.

This makes use of the previous enhancement to mtest2make.py to introduce
new meson suites 'block-$FORMAT-optional', which translate to new top
level make targets 'check-block-$FORMAT'. These new targets always run
all tests and as such do not need the SPEED variable to be set, but are
not triggered by 'make check' or 'make check-block'.

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 tests/Makefile.include         | 3 ++-
 tests/qemu-iotests/meson.build | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/Makefile.include b/tests/Makefile.include
index f257288194..a820980bbe 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -14,7 +14,8 @@ check-help:
 	@echo " $(MAKE) check-unit                    Run qobject tests"
 	@echo " $(MAKE) check-qapi-schema             Run QAPI schema tests"
 	@echo " $(MAKE) check-tracetool               Run tracetool generator tests"
-	@echo " $(MAKE) check-block                   Run block tests"
+	@echo " $(MAKE) check-block                   Run block tests (all formats)"
+	@echo " $(MAKE) check-block-FORMAT            Run block tests (only for FORMAT)"
 ifneq ($(filter $(all-check-targets), check-softfloat),)
 	@echo " $(MAKE) check-softfloat               Run FPU emulation tests"
 	@echo " $(MAKE) check-tcg                     Run TCG tests"
diff --git a/tests/qemu-iotests/meson.build b/tests/qemu-iotests/meson.build
index 1a24d801a3..16a5e39476 100644
--- a/tests/qemu-iotests/meson.build
+++ b/tests/qemu-iotests/meson.build
@@ -62,7 +62,8 @@ foreach format, speed: qemu_iotests_formats
     endforeach
   endif
 
-  suites = []
+  # Every format gets put in the format specific suite
+  suites = ['block-' + format + '-optional']
   # Any format tagged quick or slow also gets added to slow
   # otherwise its tagged thorough
   if speed != 'thorough'
-- 
2.54.0



  parent reply	other threads:[~2026-05-13 12:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 11:59 [PATCH v6 00/16] tests: do more testing of block drivers Daniel P. Berrangé
2026-05-13 11:59 ` [PATCH v6 01/16] python: bump qemu.qmp to v0.0.6 Daniel P. Berrangé
2026-05-13 11:59 ` [PATCH v6 02/16] gitlab: ensure all meson jobs capture build/meson-logs by default Daniel P. Berrangé
2026-05-13 11:59 ` [PATCH v6 03/16] tests: print reason when I/O test is skipped in TAP mode Daniel P. Berrangé
2026-05-13 11:59 ` [PATCH v6 04/16] tests: remove redundant meson suite for iotests Daniel P. Berrangé
2026-05-13 11:59 ` [PATCH v6 05/16] tests: ensure all qcow2 I/O tests are able to be run via make Daniel P. Berrangé
2026-05-13 11:59 ` [PATCH v6 06/16] scripts/mtest2make: ensure output has stable sorting Daniel P. Berrangé
2026-05-13 11:59 ` [PATCH v6 07/16] scripts/mtest2make: support optional tests grouping Daniel P. Berrangé
2026-05-13 11:59 ` Daniel P. Berrangé [this message]
2026-05-13 11:59 ` [PATCH v6 09/16] docs/devel/testing: expand documentation for 'make check-block' Daniel P. Berrangé
2026-05-13 11:59 ` [PATCH v6 10/16] tests: add nbd and luks to the I/O test suites Daniel P. Berrangé
2026-05-13 11:59 ` [PATCH v6 11/16] tests: use 'driver' as collective term for either format or protocol Daniel P. Berrangé
2026-05-13 11:59 ` [PATCH v6 12/16] tests: validate dmsetup result in test 128 Daniel P. Berrangé
2026-05-13 15:56   ` Pierrick Bouvier
2026-05-13 12:00 ` [PATCH v6 13/16] tests: fix check for sudo access in LUKS I/O test Daniel P. Berrangé
2026-05-13 12:00 ` [PATCH v6 14/16] tests/qemu-iotests: mark 185 as a flaky test Daniel P. Berrangé
2026-05-13 12:14   ` Thomas Huth
2026-05-13 15:59   ` Pierrick Bouvier
2026-05-13 12:00 ` [PATCH v6 15/16] gitlab: add jobs for thorough block tests Daniel P. Berrangé
2026-05-13 16:00   ` Pierrick Bouvier
2026-05-13 17:18     ` Daniel P. Berrangé
2026-05-13 17:21       ` Pierrick Bouvier
2026-05-13 12:00 ` [PATCH v6 16/16] gitlab: remove I/O tests from build-tcg-disabled job Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260513120003.226790-9-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=crosa@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=pierrick.bouvier@linaro.org \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox