Re: [PATCH V9 04/17] iothread: introduce iothread_unsafe_get_aio_context()

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]

On Wed, Jun 24, 2026 at 03:08:38PM +0800, Zhang Chen wrote:
> diff --git a/include/system/iothread.h b/include/system/iothread.h
> index b483bbfab3..064c05e78d 100644
> --- a/include/system/iothread.h
> +++ b/include/system/iothread.h
> @@ -71,6 +71,12 @@ DECLARE_INSTANCE_CHECKER(IOThread, IOTHREAD,
>  char *iothread_get_id(IOThread *iothread);
>  IOThread *iothread_by_id(const char *id);
>  AioContext *iothread_get_aio_context(IOThread *iothread);
> +/*
> + * The iothread_unsafe_get_aio_context() is a low-level unsafe way of getting
> + * the AioContext, recommend migrating to the new API with IOThreadHolder
> + * as much as possible.

This should describe the safety concerns and when it is okay to use this
API. Something like:

  Normally the IOThread's AioContext is fetched using
  iothread_ref_and_get_aio_context(), but there are legacy callers
  without a clear ref/unref lifecycle. They cannot unref (e.g. because
  they do not have an IOThread pointer), so provide an unsafe way to
  fetch the AioContext without holding a reference count. This unsafe
  API serves legacy callers - do not use it in new code.

> + */
> +AioContext *iothread_unsafe_get_aio_context(IOThread *iothread);
>  AioContext *iothread_ref_and_get_aio_context(IOThread *iothread,
>                                               const IOThreadHolder *holder);
>  void iothread_put_aio_context(IOThread *iothread, const IOThreadHolder *holder);

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]