From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84962C5B572 for ; Tue, 11 Aug 2026 14:38:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wtnan-0000j1-4b; Tue, 11 Aug 2026 10:36:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wtnaJ-0000Hd-IA for qemu-devel@nongnu.org; Tue, 11 Aug 2026 10:36:07 -0400 Received: from mail-qv1-xf31.google.com ([2607:f8b0:4864:20::f31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wtnaH-0001rn-LY for qemu-devel@nongnu.org; Tue, 11 Aug 2026 10:36:07 -0400 Received: by mail-qv1-xf31.google.com with SMTP id 6a1803df08f44-902fc790cd5so5349046d6.1 for ; Tue, 11 Aug 2026 07:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786458964; x=1787063764; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zpSRcEvnq+BmsAIlkLLSnlEtom+iVDnXoYuMZfKwtno=; b=QgUWkJuo/G++rSLBsMqc/FLSxiyMQdM+ckLhOfU/BGfIGT2ZAYqsXRNWw9dRqRulVJ dZf1Y14fNh/ucXjR7fjXCQ9R1jyOGoCYKM90/AbbxIKzbCj1kWBv0XXBLJ0ABid+4Fyo NCd7UBQ2Wc3p8OOo7vtXUTlDQLIf5CE3063rL3c8OFYDat9wTzVgdM8unziVAGxaPmTI iCef+6umfxVhzKlHZcTdUFL56BJnnnORCiG6cIjpBhAEJlcE9Ikl99vXUJ8EzqUHhttM Ot9cmHlGm85xRMCfffXLHy+zJL9XQnXUohbELhmmLLjWghfYZi7LHgNpSHG5GnbDkmcZ lsfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786458964; x=1787063764; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=zpSRcEvnq+BmsAIlkLLSnlEtom+iVDnXoYuMZfKwtno=; b=TNXz42PD68RYNX6VkEYBQXyJi/iFRGQcLm78qnT60/CG/S8myXGTa1Skh0eAxU/ALV MV2PbVhTjnlnrYnvB+/44MNs20v/7CI//HuZ+vlL8zyPEGRgJ+b3Rmp+dK3O0+oEirMT SxSPiOMugx+AFt3WSEcOtMYHFFAp3yc08PLYG20aVAw0mCxaQgI1vMNVp5sRxDrw/LED AhK3MM6+4S18IgZRe4xTu/6x0QlTcLP82uxJgOG7bpY6QiV1Jnd2GedGNZAKUTXqDTrW n7DDrYyjLXW+PR2VUZ3aT9/KD8jgVDGqABaj2yHFdRJu36ja59u+4A+RDoB0FkcwFR+y V7xw== X-Gm-Message-State: AOJu0YykYgFLErt04nn9u1i6LEhP8DqtpYbqbNE4c51otKhrE/x8CVRO OvNheYtrhThB452JqT6WsI3Rz/5IIAKEIeVj14R9Wixak9a14jHlp74Js10kBw== X-Gm-Gg: AR+sD13M7hQ4OZ66Zc5h7B8sB40hhaJclUTKIcqEo326ldFp66SdN9XOGtUD573T7V3 gpn5NkrCjnZDJHFAu0tqeXnDN9A+hMrlJUOoLrwfKzkP/8LWxduVv/Ind5TNXP1qs9HdRcDwoS5 5ROjnanzNNRP42T+/LV/fSH32X2CCYZM08J2fQQch1XRhxR2r2dexx/txoIl/CpRVszOL9SuJK9 Q40OxlOWjMD5PDUulzpW1NlCjwybS10QzhgLALPq3J9spfRi0G00GNZ3MTiR7uerxCgNQJBxe8h HTxMMljauyId80s7FKpH3NEbjglvc9vObmfBL86FFNeh2bqxgb3T9NRuGW9VXsPfOM/BgNdCx/V vpPSaXimmeRRx5aC4wUdLPXRlqyANgvHdbF3YbmE8OknE+2L2ojucoRpc+heML9M9FoAOXejLwI PbFvUSvUIUdj/SSgzjljzDW7FAx6WNEK2Ljaa74KNFFxZUei4kFrf4P0pklCSYh4NscihWyx12H 4G2W/fZ/t6eN1tVfWwIabYwAxHLjg== X-Received: by 2002:a05:6214:40a:b0:8cc:d29:9f78 with SMTP id 6a1803df08f44-90a6c0ee9d6mr3772446d6.11.1786458964309; Tue, 11 Aug 2026 07:36:04 -0700 (PDT) Received: from localhost.localdomain ([198.16.145.87]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90a6c26e074sm681286d6.2.2026.08.11.07.36.03 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 11 Aug 2026 07:36:04 -0700 (PDT) From: Marcelo Manzo To: qemu-devel@nongnu.org, qemu-arm@nongnu.org Cc: Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Sergey Kambalin , Sergey Kambalin , Marcelo Manzo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jason Wang Subject: [PATCH v2 05/19] hw/net/bcm2838_genet: add GENET register structs, part 1/4 Date: Tue, 11 Aug 2026 10:35:42 -0400 Message-ID: <20260811143557.7862-6-marcelomanzo@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260811143557.7862-1-marcelomanzo@gmail.com> References: <20260811143557.7862-1-marcelomanzo@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::f31; envelope-from=marcelomanzo@gmail.com; helo=mail-qv1-xf31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org From: Sergey Kambalin Add the SYS, GR_BRIDGE, EXT, INTRL0, and INTRL1 register block layouts and the top-level BCM2838GenetRegs/BCM2838GenetState structs, plus REG32/FIELD accessors for the revision-control and interrupt-status registers. Part of Sergey Kambalin's original Raspberry Pi 4B PCIe/GENET networking series (patchwork series 829638, posted to qemu-devel in 2024, never merged). Carried forward and completed by Marcelo Manzo. Signed-off-by: Sergey Kambalin Signed-off-by: Marcelo Manzo --- hw/net/bcm2838_genet.c | 37 ++++++++++++++++ include/hw/net/bcm2838_genet.h | 77 +++++++++++++++++++++++++++++++++- 2 files changed, 113 insertions(+), 1 deletion(-) diff --git a/hw/net/bcm2838_genet.c b/hw/net/bcm2838_genet.c index 2ff93a3417..ff6602c1f3 100644 --- a/hw/net/bcm2838_genet.c +++ b/hw/net/bcm2838_genet.c @@ -15,10 +15,47 @@ #include "hw/core/irq.h" #include "net/checksum.h" #include "system/dma.h" +#include "hw/core/registerfields.h" #include "hw/core/resettable.h" #include "hw/net/bcm2838_genet.h" #include "trace.h" +REG32(GENET_SYS_REV_CTRL, 0) +FIELD(GENET_SYS_REV_CTRL, GPHY_REV, 0, 16) +FIELD(GENET_SYS_REV_CTRL, MINOR_REV, 16, 4) +FIELD(GENET_SYS_REV_CTRL, RSVD_20_23, 20, 4) +FIELD(GENET_SYS_REV_CTRL, MAJOR_REV, 24, 4) +FIELD(GENET_SYS_REV_CTRL, RSVD_28_31, 28, 4) + +REG32(GENET_INTRL_0, 0) +FIELD(GENET_INTRL_0, SCB, 0, 1) +FIELD(GENET_INTRL_0, EPHY, 1, 1) +FIELD(GENET_INTRL_0, PHY_DET_R, 2, 1) +FIELD(GENET_INTRL_0, PHY_DET_F, 3, 1) +FIELD(GENET_INTRL_0, LINK_UP, 4, 1) +FIELD(GENET_INTRL_0, LINK_DOWN, 5, 1) +FIELD(GENET_INTRL_0, UMAC, 6, 1) +FIELD(GENET_INTRL_0, UMAC_TSV, 7, 1) +FIELD(GENET_INTRL_0, TBUF_UNDERRUN, 8, 1) +FIELD(GENET_INTRL_0, RBUF_OVERFLOW, 9, 1) +FIELD(GENET_INTRL_0, HFB_SM, 10, 1) +FIELD(GENET_INTRL_0, HFB_MM, 11, 1) +FIELD(GENET_INTRL_0, MPD_R, 12, 1) +FIELD(GENET_INTRL_0, RXDMA_MBDONE, 13, 1) +FIELD(GENET_INTRL_0, RXDMA_PDONE, 14, 1) +FIELD(GENET_INTRL_0, RXDMA_BDONE, 15, 1) +FIELD(GENET_INTRL_0, TXDMA_MBDONE, 16, 1) +FIELD(GENET_INTRL_0, TXDMA_PDONE, 17, 1) +FIELD(GENET_INTRL_0, TXDMA_BDONE, 18, 1) +FIELD(GENET_INTRL_0, RSVD_19_22, 19, 4) +FIELD(GENET_INTRL_0, MDIO_DONE, 23, 1) +FIELD(GENET_INTRL_0, MDIO_ERROR, 24, 1) +FIELD(GENET_INTRL_0, RSVD_25_31, 25, 4) + +REG32(GENET_INTRL_1, 0) +FIELD(GENET_INTRL_1, TX_INTRS, 0, 16) +FIELD(GENET_INTRL_1, RX_INTRS, 16, 16) + static uint64_t bcm2838_genet_read(void *opaque, hwaddr offset, unsigned size) { diff --git a/include/hw/net/bcm2838_genet.h b/include/hw/net/bcm2838_genet.h index 91cf1773d5..af5e8abd2e 100644 --- a/include/hw/net/bcm2838_genet.h +++ b/include/hw/net/bcm2838_genet.h @@ -19,7 +19,82 @@ OBJECT_DECLARE_SIMPLE_TYPE(BCM2838GenetState, BCM2838_GENET) #define BCM2838_GENET_REV_MINOR 0 typedef struct { - uint8_t stub_area[0x10000]; /* temporary stub */ + uint32_t rev_ctrl; + uint32_t port_ctrl; + uint32_t rbuf_flush_ctrl; + uint32_t tbuf_flush_ctrl; + uint32_t reserved_0x10[12]; +} BCM2838GenetRegsSys; + +typedef struct { + uint32_t reserved_0x0[16]; +} BCM2838GenetRegsGrBridge; + +typedef struct { + uint32_t pwr_mgmt; + uint32_t reserved_0x4[2]; + uint32_t rgmii_oob_ctrl; + uint32_t reserved_0x10[3]; + uint32_t gphy_ctrl; + uint32_t reserved_0x20[24]; +} BCM2838GenetRegsExt; + +typedef struct { + uint32_t stat; + uint32_t set; + uint32_t clear; + uint32_t mask_status; + uint32_t mask_set; + uint32_t mask_clear; + uint32_t reserved_0x18[10]; +} BCM2838GenetRegsIntrl0; + +typedef struct { + uint32_t stat; + uint32_t set; + uint32_t clear; + uint32_t mask_status; + uint32_t mask_set; + uint32_t mask_clear; + uint32_t reserved_0x18[10]; +} BCM2838GenetRegsIntrl1; + +typedef struct { + uint32_t ctrl; + uint32_t reserved_0x4[2]; + uint32_t status; + uint32_t reserved_0x10; + uint32_t chk_ctrl; + uint32_t reserved_0x18[31]; + uint32_t ovfl_cnt; + uint32_t err_cnt; + uint32_t energy_ctrl; + uint32_t reserved_0xA0[5]; + uint32_t size_ctrl; + uint32_t reserved_0xB8[18]; +} BCM2838GenetRegsRbuf; + +typedef struct { + uint32_t ctrl; + uint32_t reserved_0x4[2]; + uint32_t bp_mc; + uint32_t reserved_0x10; + uint32_t energy_ctrl; + uint32_t reserved_0x18[58]; +} BCM2838GenetRegsTbuf; + +typedef struct { + BCM2838GenetRegsSys sys; + BCM2838GenetRegsGrBridge gr_bridge; + BCM2838GenetRegsExt ext; + uint32_t reserved_0x100[64]; + BCM2838GenetRegsIntrl0 intrl0; + BCM2838GenetRegsIntrl1 intrl1; + uint32_t reserved_0x280[32]; + BCM2838GenetRegsRbuf rbuf; + uint32_t reserved_0x400[128]; + BCM2838GenetRegsTbuf tbuf; + uint32_t reserved_0x700[64]; } BCM2838GenetRegs; struct BCM2838GenetState { -- 2.47.1