From: Stefan Hajnoczi <stefanha@redhat.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Sam Li <faithilikerun@gmail.com>,
Damien Le Moal <dlemoal@kernel.org>
Subject: Re: [PATCH v2] file-posix: fix zone write granularity assignment for zoned block devices
Date: Wed, 12 Aug 2026 11:03:25 -0400 [thread overview]
Message-ID: <20260812150324.GE244786@fedora> (raw)
In-Reply-To: <20260811133236.1290092-1-cassel@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1154 bytes --]
On Tue, Aug 11, 2026 at 03:32:36PM +0200, Niklas Cassel wrote:
> In the ZBC and ZAC specifications, the requirement is that the write
> granularity matches the physical block size.
>
> However, in the ZNS specification, the requirement is simply that the
> write granularity matches the logical block size.
>
> See:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a805a4fa4fa376bbc145762bb8b09caa2fa8af48
>
> In Linux, there is a zone_write_granularity sysfs property which abstracts
> this away, so let's make use of it.
>
> Currently, it is theoretically possible that QEMU presents an inflated
> write granularity for NVMe devices where the physical block size is larger
> than the logical block size.
>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> Fixes: a3c41f06d5a8 ("file-posix: add tracking of the zone write pointers")
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
> ---
> Changes since v1:
> -Improved commit log.
> -Picked up tag.
>
> block/file-posix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-08-12 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 13:32 [PATCH v2] file-posix: fix zone write granularity assignment for zoned block devices Niklas Cassel
2026-08-12 15:03 ` Stefan Hajnoczi [this message]
2026-08-19 17:13 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812150324.GE244786@fedora \
--to=stefanha@redhat.com \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=faithilikerun@gmail.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox