QEMU-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Konstantin Shkolnyy <kshk@linux.ibm.com>
To: mjrosato@linux.ibm.com
Cc: alifm@linux.ibm.com, farman@linux.ibm.com,
	richard.henderson@linaro.org, iii@linux.ibm.com,
	david@kernel.org, cohuck@redhat.com, pasic@linux.ibm.com,
	borntraeger@linux.ibm.com, qemu-s390x@nongnu.org,
	qemu-devel@nongnu.org, Konstantin Shkolnyy <kshk@linux.ibm.com>
Subject: [PATCH v7 06/15] s390x/pci: Remove a ptr to S390PCIBusDevice from S390PCIIOMMU
Date: Tue, 18 Aug 2026 12:25:12 -0500	[thread overview]
Message-ID: <20260818172521.223460-7-kshk@linux.ibm.com> (raw)
In-Reply-To: <20260818172521.223460-1-kshk@linux.ibm.com>

This pointer is no longer used, after fields were moved from S390PCIIOMMU
to S390PCIBusDevice.

Reviewed-by: Farhan Ali<alifm@linux.ibm.com>
Signed-off-by: Konstantin Shkolnyy <kshk@linux.ibm.com>
---
 hw/s390x/s390-pci-bus.c         | 15 +++++++--------
 include/hw/s390x/s390-pci-bus.h |  1 -
 2 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index a08f226ef8..d2abbdab7f 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -552,7 +552,7 @@ static IOMMUTLBEntry s390_translate_iommu(IOMMUMemoryRegion *mr, hwaddr addr,
         .perm = IOMMU_NONE,
     };
 
-    switch (iommu->pbdev->state) {
+    switch (pbdev->state) {
     case ZPCI_FS_ENABLED:
     case ZPCI_FS_BLOCKED:
         if (!iommu->enabled) {
@@ -587,9 +587,9 @@ static IOMMUTLBEntry s390_translate_iommu(IOMMUMemoryRegion *mr, hwaddr addr,
     }
 err:
     if (error) {
-        iommu->pbdev->state = ZPCI_FS_ERROR;
-        s390_pci_generate_error_event(error, iommu->pbdev->fh,
-                                      iommu->pbdev->fid, addr, 0);
+        pbdev->state = ZPCI_FS_ERROR;
+        s390_pci_generate_error_event(error, pbdev->fh,
+                                      pbdev->fid, addr, 0);
     }
     return ret;
 }
@@ -780,7 +780,7 @@ void s390_pci_iommu_enable(S390PCIBusDevice *pbdev)
      * so the smallest IOMMU region we can define runs from 0 to the end
      * of the PCI address space.
      */
-    char *name = g_strdup_printf("iommu-s390-%04x", iommu->pbdev->uid);
+    char *name = g_strdup_printf("iommu-s390-%04x", pbdev->uid);
     memory_region_init_iommu(&pbdev->iommu_mr, sizeof(pbdev->iommu_mr),
                              TYPE_S390_IOMMU_MEMORY_REGION, OBJECT(&iommu->mr),
                              name, iommu->pal + 1);
@@ -801,14 +801,14 @@ void s390_pci_iommu_direct_map_enable(S390PCIBusDevice *pbdev)
      * IOVA X + SDMA.  VFIO will handle pinning via its memory listener.
      */
     g_autofree char *name = g_strdup_printf("iommu-dm-s390-%04x",
-                                            iommu->pbdev->uid);
+                                            pbdev->uid);
 
     pbdev->dm_mr = g_malloc0(sizeof(*pbdev->dm_mr));
     memory_region_init_alias(pbdev->dm_mr, OBJECT(&iommu->mr), name,
                              get_system_memory(), 0,
                              s390_get_memory_limit(s390ms));
     iommu->enabled = true;
-    memory_region_add_subregion(&iommu->mr, iommu->pbdev->zpci_fn.sdma,
+    memory_region_add_subregion(&iommu->mr, pbdev->zpci_fn.sdma,
                                 pbdev->dm_mr);
 }
 
@@ -1200,7 +1200,6 @@ static void s390_pcihost_plug(HotplugHandler *hotplug_dev, DeviceState *dev,
 
         pbdev->pdev = pdev;
         pbdev->iommu = s390_pci_get_iommu(s, pci_get_bus(pdev), pdev->devfn);
-        pbdev->iommu->pbdev = pbdev;
         pbdev->state = ZPCI_FS_DISABLED;
         set_pbdev_info(pbdev);
 
diff --git a/include/hw/s390x/s390-pci-bus.h b/include/hw/s390x/s390-pci-bus.h
index d9bafd6859..fcaaf19512 100644
--- a/include/hw/s390x/s390-pci-bus.h
+++ b/include/hw/s390x/s390-pci-bus.h
@@ -273,7 +273,6 @@ typedef struct S390PCIDMACount {
 
 struct S390PCIIOMMU {
     Object parent_obj;
-    S390PCIBusDevice *pbdev;
     AddressSpace as;
     MemoryRegion mr;
     bool enabled;
-- 
2.34.1



  parent reply	other threads:[~2026-08-18 17:26 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 17:25 [PATCH v7 00/15] s390x/pci: Implement migration for emulated devices Konstantin Shkolnyy
2026-08-18 17:25 ` [PATCH v7 01/15] s390x/pci: implement IOMMU replay Konstantin Shkolnyy
2026-08-18 17:25 ` [PATCH v7 02/15] s390x/pci: Create function to contain translation status check Konstantin Shkolnyy
2026-08-24 21:27   ` Matthew Rosato
2026-08-18 17:25 ` [PATCH v7 03/15] s390x/pci: Move iommu_mr from S390PCIIOMMU to S390PCIBusDevice Konstantin Shkolnyy
2026-08-24 20:50   ` Matthew Rosato
2026-08-18 17:25 ` [PATCH v7 04/15] s390x/pci: Move dm_mr " Konstantin Shkolnyy
2026-08-24 20:55   ` Matthew Rosato
2026-08-18 17:25 ` [PATCH v7 05/15] s390x/pci: Move iotlb " Konstantin Shkolnyy
2026-08-24 21:12   ` Matthew Rosato
2026-08-18 17:25 ` Konstantin Shkolnyy [this message]
2026-08-24 21:15   ` [PATCH v7 06/15] s390x/pci: Remove a ptr to S390PCIBusDevice from S390PCIIOMMU Matthew Rosato
2026-08-18 17:25 ` [PATCH v7 07/15] s390x/pci: Move/rename enabled from S390PCIIOMMU to S390PCIBusDevice Konstantin Shkolnyy
2026-08-24 21:18   ` Matthew Rosato
2026-08-18 17:25 ` [PATCH v7 08/15] s390x/pci: Move dma_limit " Konstantin Shkolnyy
2026-08-24 21:28   ` Matthew Rosato
2026-08-18 17:25 ` [PATCH v7 09/15] s390x/pci: Move g_iota " Konstantin Shkolnyy
2026-08-24 21:32   ` Matthew Rosato
2026-08-18 17:25 ` [PATCH v7 10/15] s390x/pci: Move pba " Konstantin Shkolnyy
2026-08-24 21:36   ` Matthew Rosato
2026-08-18 17:25 ` [PATCH v7 11/15] s390x/pci: Move pal " Konstantin Shkolnyy
2026-08-24 21:42   ` Matthew Rosato
2026-08-18 17:25 ` [PATCH v7 12/15] s390x/pci: Move max_dma_limit " Konstantin Shkolnyy
2026-08-24 21:58   ` Matthew Rosato
2026-08-18 17:25 ` [PATCH v7 13/15] s390x/pci: Add a comment explaining S390PCIIOMMU purpose Konstantin Shkolnyy
2026-08-24 22:00   ` Matthew Rosato
2026-08-18 17:25 ` [PATCH v7 14/15] s390x/pci: Implement migration for emulated devices Konstantin Shkolnyy
2026-08-24 22:35   ` Matthew Rosato
2026-08-18 17:25 ` [PATCH v7 15/15] s390x/pci: Create function to contain fmb_timer start Konstantin Shkolnyy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260818172521.223460-7-kshk@linux.ibm.com \
    --to=kshk@linux.ibm.com \
    --cc=alifm@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@kernel.org \
    --cc=farman@linux.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=mjrosato@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox