From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@mailo.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PATCH 1/4] meson: simplify clang version checks
Date: Thu, 3 Sep 2026 11:35:45 +0100 [thread overview]
Message-ID: <20260903103548.2142568-2-berrange@redhat.com> (raw)
In-Reply-To: <20260903103548.2142568-1-berrange@redhat.com>
The checks for the clang minor versions are currently redundant since
there can never be a minor version less than zero. Going forward it
is likely sufficient to always pick a NN.0.0 release as the min CLang
version, so drop the minor version checks.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index 5c9de307b0..70e2755149 100644
--- a/meson.build
+++ b/meson.build
@@ -330,11 +330,11 @@ foreach lang : all_languages
# ok
elif compiler.get_id() == 'clang' and compiler.compiles('''
#ifdef __apple_build_version__
- # if __clang_major__ < 15 || (__clang_major__ == 15 && __clang_minor__ < 0)
+ # if __clang_major__ < 15
# error You need at least XCode Clang v15.0 to compile QEMU
# endif
#else
- # if __clang_major__ < 10 || (__clang_major__ == 10 && __clang_minor__ < 0)
+ # if __clang_major__ < 10
# error You need at least Clang v10.0 to compile QEMU
# endif
#endif''')
--
2.55.0
next prev parent reply other threads:[~2026-09-03 10:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 10:35 [PATCH 0/4] Bump min compiler versions again Daniel P. Berrangé
2026-09-03 10:35 ` Daniel P. Berrangé [this message]
2026-09-03 11:35 ` [PATCH 1/4] meson: simplify clang version checks Marc-André Lureau
2026-09-03 11:37 ` Daniel P. Berrangé
2026-09-03 10:35 ` [PATCH 2/4] meson: bump min XCode CLang to 17.0 Daniel P. Berrangé
2026-09-03 10:41 ` Philippe Mathieu-Daudé
2026-09-03 10:35 ` [PATCH 3/4] meson: bump min upstream " Daniel P. Berrangé
2026-09-03 11:30 ` Marc-André Lureau
2026-09-03 10:35 ` [PATCH 4/4] meson: warn on GCC < 12.0 due to lack of -ftrivial-auto-var-init=zero Daniel P. Berrangé
2026-09-03 11:28 ` Marc-André Lureau
2026-09-03 16:22 ` [PATCH 0/4] Bump min compiler versions again Pierrick Bouvier
2026-09-10 18:04 ` Richard Henderson
2026-09-10 18:24 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903103548.2142568-2-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@mailo.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox