From: Thomas Huth <thuth@redhat.com>
To: quintela@redhat.com
Cc: lvivier@redhat.com, qemu-devel@nongnu.org, peterx@redhat.com,
dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test
Date: Wed, 4 Oct 2017 15:07:45 +0200 [thread overview]
Message-ID: <2031be1e-62d1-1605-1f11-24868fbbc635@redhat.com> (raw)
In-Reply-To: <87infvgjx1.fsf@secure.laptop>
On 04.10.2017 14:46, Juan Quintela wrote:
> Thomas Huth <thuth@redhat.com> wrote:
>> On 04.10.2017 12:39, Juan Quintela wrote:
>>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
>>
>> Looks like a lot of this code is the same or very similar to the code in
>> postcopy-test.c ... would it make sense to factor-out that code there
>> into a separate file that could be used by both tests, so that we do not
>> have to maintain the code twice?
>
>
> I think I put that on the cover letter, my idea is to add the postcopy
> test here.
OK, then I think you should remove the duplicated functions from
postcopy-test.c in the same patch here, so that it is more obvious that
this is a code movement.
Thomas
PS: Please also add an entry to MAINTAINERS for the new files if feasible.
next prev parent reply other threads:[~2017-10-04 13:07 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 10:39 [Qemu-devel] [PATCH 0/6] Add make check tests for Migration Juan Quintela
2017-10-04 10:39 ` [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test Juan Quintela
2017-10-04 12:33 ` Thomas Huth
2017-10-04 12:46 ` Juan Quintela
2017-10-04 13:07 ` Thomas Huth [this message]
2017-10-04 15:52 ` Eric Blake
2017-10-09 8:19 ` Peter Xu
2017-10-18 11:49 ` Juan Quintela
2017-10-16 11:59 ` Dr. David Alan Gilbert
2017-10-18 4:26 ` Peter Xu
2017-10-18 11:36 ` Juan Quintela
2017-10-18 12:10 ` Daniel P. Berrange
2017-10-19 3:18 ` Peter Xu
2017-10-19 9:09 ` Daniel P. Berrange
2017-10-19 9:16 ` Dr. David Alan Gilbert
2017-10-19 9:19 ` Daniel P. Berrange
2017-10-19 9:23 ` Dr. David Alan Gilbert
2017-10-19 9:09 ` Dr. David Alan Gilbert
2017-10-18 12:03 ` Daniel P. Berrange
2017-10-18 12:49 ` Dr. David Alan Gilbert
2017-10-18 13:08 ` Daniel P. Berrange
2017-10-04 10:39 ` [Qemu-devel] [PATCH 2/6] tests: Add basic migration precopy tcp test Juan Quintela
2017-10-16 12:09 ` Dr. David Alan Gilbert
2017-10-18 11:51 ` Juan Quintela
2017-10-04 10:39 ` [Qemu-devel] [PATCH 3/6] tests: Add precopy test using deprecated commands Juan Quintela
2017-10-16 15:40 ` Dr. David Alan Gilbert
2017-10-18 11:52 ` Juan Quintela
2017-10-04 10:39 ` [Qemu-devel] [PATCH 4/6] tests: Add migration xbzrle test Juan Quintela
2017-10-16 16:07 ` Dr. David Alan Gilbert
2017-10-18 11:56 ` Juan Quintela
2017-10-19 9:06 ` Dr. David Alan Gilbert
2017-10-04 10:39 ` [Qemu-devel] [PATCH 5/6] tests: Add migration compress threads tests Juan Quintela
2017-10-09 8:28 ` Peter Xu
2017-10-18 11:59 ` Juan Quintela
2017-10-16 16:29 ` Dr. David Alan Gilbert
2017-10-18 11:57 ` Juan Quintela
2017-10-04 10:39 ` [Qemu-devel] [PATCH 6/6] tests: Move postcopy migration test to migrate-set-parameters Juan Quintela
2017-10-16 16:31 ` Dr. David Alan Gilbert
2017-10-04 13:25 ` [Qemu-devel] [PATCH 0/6] Add make check tests for Migration no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2031be1e-62d1-1605-1f11-24868fbbc635@redhat.com \
--to=thuth@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).