From: Paolo Bonzini <pbonzini@redhat.com>
To: Fabio Fantoni <fabio.fantoni@m2r.biz>
Cc: xen-devel@lists.xensource.com, "Wei Liu" <wei.liu2@citrix.com>,
"Ian Campbell" <Ian.Campbell@citrix.com>,
"Stefano Stabellini" <stefano.stabellini@eu.citrix.com>,
"Ian Jackson" <Ian.Jackson@eu.citrix.com>,
qemu-devel@nongnu.org, "Hans de Goede" <hdegoede@redhat.com>,
spice-devel@lists.freedesktop.org,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH] libxl: Spice usbredirection support for upstream qemu
Date: Fri, 5 Jul 2013 05:02:56 -0400 (EDT) [thread overview]
Message-ID: <2039015654.6402905.1373014976350.JavaMail.root@redhat.com> (raw)
In-Reply-To: <51D686F6.8020606@m2r.biz>
----- Messaggio originale -----
> Da: "Fabio Fantoni" <fabio.fantoni@m2r.biz>
> A: "Paolo Bonzini" <pbonzini@redhat.com>
> Cc: "Andreas Färber" <afaerber@suse.de>, "Stefano Stabellini" <stefano.stabellini@eu.citrix.com>,
> xen-devel@lists.xensource.com, "Wei Liu" <wei.liu2@citrix.com>, "Ian Campbell" <Ian.Campbell@citrix.com>, "Ian
> Jackson" <Ian.Jackson@eu.citrix.com>, qemu-devel@nongnu.org, "Hans de Goede" <hdegoede@redhat.com>,
> spice-devel@lists.freedesktop.org
> Inviato: Venerdì, 5 luglio 2013 10:42:30
> Oggetto: Re: [Xen-devel] [PATCH] libxl: Spice usbredirection support for upstream qemu
>
> Il 04/07/2013 22:09, Paolo Bonzini ha scritto:
> > Il 04/07/2013 19:17, Andreas Färber ha scritto:
> >> Also if at some point you try to use, e.g., q35 rather than i440fx
> >> machine, it might have EHCI by default and the snippet would be
> >> instantiating a duplicate one. I.e., the three levels of dependency
> >> could be separated more clearly: PCI, USB, redirection.
> > At least you could start specifying the USB desired version (1.1, 2.0
> > with companion controllers, 3.0) as an extension of the "usb=1" that is
> > already supported.
> >
> > Paolo
>
> Thanks and sorry, I found only now that is working also with only
> -device usb-ehci,id=usb.
> I'll post a new patch version.
With only the EHCI you might have problems redirecting USB 1.1 devices.
The EHCI+UHCI magic is the right thing to do for USB 2.0 support on x86.
What Andreas and I were suggesting was to split the patch in two parts:
first adding support for USB 2.0/3.0, and only then adding redirection
(perhaps with the possibility to customize how many redirected devices
to support).
Paolo
next prev parent reply other threads:[~2013-07-05 9:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1372932359-4625-1-git-send-email-fabio.fantoni@m2r.biz>
[not found] ` <20130704101203.GS7483@zion.uk.xensource.com>
[not found] ` <51D54B8B.9010703@m2r.biz>
[not found] ` <20130704103224.GT7483@zion.uk.xensource.com>
2013-07-04 12:04 ` [Qemu-devel] [Xen-devel] [PATCH] libxl: Spice usbredirection support for upstream qemu Fabio Fantoni
2013-07-04 12:46 ` Stefano Stabellini
2013-07-04 17:17 ` Andreas Färber
2013-07-04 20:09 ` Paolo Bonzini
2013-07-05 8:42 ` Fabio Fantoni
2013-07-05 9:02 ` Paolo Bonzini [this message]
2013-07-05 9:27 ` Fabio Fantoni
2013-07-05 10:18 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2039015654.6402905.1373014976350.JavaMail.root@redhat.com \
--to=pbonzini@redhat.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=afaerber@suse.de \
--cc=fabio.fantoni@m2r.biz \
--cc=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=spice-devel@lists.freedesktop.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).