From: Eric Blake <eblake@redhat.com>
To: Dominik Csapak <d.csapak@proxmox.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com, armbru@redhat.com,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/3] qapi: Split host-qmp into quit and system-reset
Date: Mon, 3 Dec 2018 15:38:40 -0600 [thread overview]
Message-ID: <20470290-837c-e137-ec6b-4a0179195597@redhat.com> (raw)
In-Reply-To: <20181203092617.24090-4-d.csapak@proxmox.com>
On 12/3/18 3:26 AM, Dominik Csapak wrote:
> It is interesting to know whether the shutdown cause was 'quit' or
> 'reset', especially when using "--no-reboot". In that case, a management
> layer can now determine if the guest wanted a reboot or shutdown, and
> can act accordingly.
>
> Changes the ouput of the reason in the iotests from 'host-qmp' to
s/ouput/output/
> 'host-qmp-quit'.
May be worth adding that this change is not a compatibility break,
because the field itself was also added in 4.0.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> qapi/run-state.json | 10 ++++++----
Otherwise, series is looking good to me.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-12-03 21:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 9:26 [Qemu-devel] [PATCH v2 0/3] qapi: return ShutdownCause for events Dominik Csapak
2018-12-03 9:26 ` [Qemu-devel] [PATCH v2 1/3] qapi: Turn ShutdownCause into QAPI enum Dominik Csapak
2018-12-03 12:23 ` Markus Armbruster
2018-12-03 21:34 ` Eric Blake
2018-12-04 7:25 ` Dominik Csapak
2018-12-03 9:26 ` [Qemu-devel] [PATCH v2 2/3] qapi: Add reason to SHUTDOWN and RESET events Dominik Csapak
2018-12-03 12:26 ` Markus Armbruster
2018-12-03 21:30 ` Eric Blake
2018-12-04 5:37 ` Markus Armbruster
2018-12-03 21:36 ` Eric Blake
2018-12-04 7:26 ` Dominik Csapak
2018-12-03 9:26 ` [Qemu-devel] [PATCH v2 3/3] qapi: Split host-qmp into quit and system-reset Dominik Csapak
2018-12-03 12:28 ` Markus Armbruster
2018-12-03 21:38 ` Eric Blake [this message]
2018-12-04 7:27 ` Dominik Csapak
2018-12-03 12:29 ` [Qemu-devel] [PATCH v2 0/3] qapi: return ShutdownCause for events Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20470290-837c-e137-ec6b-4a0179195597@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=d.csapak@proxmox.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).