From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC204C77B72 for ; Wed, 12 Apr 2023 12:52:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmZww-00059p-EC; Wed, 12 Apr 2023 08:51:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmZvn-0003a1-5q for qemu-devel@nongnu.org; Wed, 12 Apr 2023 08:50:35 -0400 Received: from mga11.intel.com ([192.55.52.93]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmZvk-0000hP-2A for qemu-devel@nongnu.org; Wed, 12 Apr 2023 08:50:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681303832; x=1712839832; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=nSUwv2OavEbHNkO4sNRnv+yyYto86nHLbli6tmmFcsY=; b=EbHjrzG3pllGrgjfOlEw8BGkFVG0t5Y7B1dGoonxoEbnH8vWVGZ2TpRA JsYpKW4+iXdyzw0uLMBX+TWxkl4YUvurNII8sLjgfY/AdNF6Qi0lioA+a jqTUo7Wri+tS81uDbO8Ae7UFclOzLh+rFNHO5Wf5IYdOjb70Uh45EY37l 8kaEtA/IsZ6QOHVT4mJFdUn027yLik3U2uvDNOE+U1iudIBPHKSOyUN4J Nr1usa/LhY37fOD7S+7MiQbtOOFpGtABBAkEMHU0tE2Cixv1tH87WSEIA tu10zWVC7AqFyu9t+byWiNCu/XFwFwlo77p6IGvUoWWwXpsnhWAezKotI w==; X-IronPort-AV: E=McAfee;i="6600,9927,10678"; a="341376205" X-IronPort-AV: E=Sophos;i="5.98,339,1673942400"; d="scan'208";a="341376205" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2023 05:50:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10678"; a="682470690" X-IronPort-AV: E=Sophos;i="5.98,339,1673942400"; d="scan'208";a="682470690" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 12 Apr 2023 05:50:22 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 12 Apr 2023 05:50:22 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 12 Apr 2023 05:50:22 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 12 Apr 2023 05:50:22 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 12 Apr 2023 05:50:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eErzDatjiM05xs2DwvZ9si67rgmM19zar4RhHBzqYAUSFCZD9pM2v0P8oaQHa7vCy/A8hx27TF8PAMv2m2q1dt6XDyDRyKAnxPQsu2BF7qDnQqxECAc+EIG9LpgmPKgCrsdH+v4oAQwwEa0eu6UCzoz30nBdTXGfgxc0xYCkspDi2x3QExcWDmqG47vfX/GDIpgCehMqLw1OFCshrY0cAhCBIW6qw17frMC99Gisb4bWpUmI/ZZ3wstEgO1oeWVbVGIynj428pjEme7FC6t61umCa95lBcfd4rctyxRBRxpzVIm+OVYUyKV5/kZ266Vf1LAxJ96ir5DMx+/PFU29mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pfGXxNAFgvk79uexf+HhpzhEu7sqnMj6RGpYlwE2heo=; b=V38ytpFMG3Px1DXnRcJKFVX0cLZ/gSnUqQBfMJeAbcNdWOtYHO5LlgIDaQHAxpJPZKFKtkF5T6zkZsEBUtCye92eYhKzdR64wOv+6oVynKqVzgXiowF2u72/LeU0XDHOj14KwoiWjvfJ9QicstlpSDyBLPUDnrNQqhzeOo2C4hjjwQRAtDB2FrBFs5rLyatrpXiWjmO/fWwjojfdDfyMJ0r8mG4+p/Jm3lJA9+z/TWBLollxeTbu7iZvsIlxySQ9gWA5BL48gwHI2SWLrpvon55O64nRe/ISJQ2EZAXteNH2eJBdQNpOQoaHRb3abp42QRhOhk479GlYbJOB01mseQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BY5PR11MB4500.namprd11.prod.outlook.com (2603:10b6:a03:1c3::24) by SN7PR11MB7137.namprd11.prod.outlook.com (2603:10b6:806:2a0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Wed, 12 Apr 2023 12:50:20 +0000 Received: from BY5PR11MB4500.namprd11.prod.outlook.com ([fe80::cf58:e1db:41d4:ee3f]) by BY5PR11MB4500.namprd11.prod.outlook.com ([fe80::cf58:e1db:41d4:ee3f%6]) with mapi id 15.20.6277.038; Wed, 12 Apr 2023 12:50:20 +0000 Message-ID: <204c0ffc-4798-38f4-41ac-5340a12a8b49@intel.com> Date: Wed, 12 Apr 2023 20:50:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/2] accel/tcg/plugin: export host insn size To: =?UTF-8?Q?Alex_Benn=c3=a9e?= CC: Richard Henderson , , , , References: <20230406022751.757980-1-fei2.wu@intel.com> <20230406022751.757980-2-fei2.wu@intel.com> <87v8i9jviv.fsf@linaro.org> <87ttxoc8wq.fsf@linaro.org> <0f237ccb-dcbe-87c7-d9f2-653962d30520@intel.com> <87v8i2ri3w.fsf@linaro.org> Content-Language: en-US From: "Wu, Fei" In-Reply-To: <87v8i2ri3w.fsf@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR04CA0175.apcprd04.prod.outlook.com (2603:1096:4:14::13) To BY5PR11MB4500.namprd11.prod.outlook.com (2603:10b6:a03:1c3::24) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR11MB4500:EE_|SN7PR11MB7137:EE_ X-MS-Office365-Filtering-Correlation-Id: b0f4cba4-9898-4224-ed5e-08db3b5478d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8QnnvTvdJEsSieopXd/3rqGF0kedF4yQjlAFUJ4bFIBVmXlFKEhdLGVS17JMcVZwVSe+uCYvmgiZsLBPzseBgT0WUAI1eMhald3ocJ+ankXjnWh/4lBmHjdm+3SYP9OGjgemHArpq2bWJ88doYwJRrpT8Pfty3yp/tKoMnBrft79nlXLx+uvXD+AxLBBh22coTdrs6XBTeW1qZR1FGccI8FE5UVd1GRDnAal/UcS35JZzCX2Dh7OR+XeuOg2KhIrF9BehQSYSGplCTuHM9EEubjbvalhewmmL056GD81LnH08xqu/sGso0sjBJnxwi4XUsU47IRz6bCKNo/Y643b51RFfJ5fDeZfJP8ZTCjBBS60dMbpVRbw0CRMbCEWXdCqKMFdA/nDWJ3ApSwVWrX81cC33Rs6mIgey/0KOgDVT8VDFzcrW4bLmGqEWkPOJvcuKqj0+08KxLcI6dgJV+HLLrFfSDFd2DNfIejhFWD5IVPoCzYWt087xDejR08KWo2zJFpC6/YE2x9oC4F02fHrPeSniUCexbqlv0XTz1N+AGT9GYQH2TuWCpFZUX8vUEX5SdNm4mjGJ5yfW7pqPnoE+xnss3xCQB8kTlkGVyHq1X6wn1W67qKnImoBY9sgE/qPfWiAc0CSzYKil7rv80q1H1iYKIzYoiLA+gNU6apuqBE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR11MB4500.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(396003)(366004)(39860400002)(346002)(136003)(376002)(451199021)(31686004)(966005)(36756003)(6486002)(66946007)(66556008)(66476007)(4326008)(6916009)(8676002)(478600001)(316002)(41300700001)(31696002)(86362001)(83380400001)(2616005)(26005)(6512007)(6666004)(6506007)(53546011)(66574015)(5660300002)(38100700002)(8936002)(186003)(82960400001)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RnF2TDV1M3JjbE5uNEN0bEJhby9RUElZRk1xUnV2QkR2bWlaVDUzSEhxQmg4?= =?utf-8?B?dGxKdmplbXVRbGlWODl5cG1KMS9memVXWm8zSG1IZTJtMm1qcTJ5QlJ0cjBs?= =?utf-8?B?ei9rUGsrQm1uNUo5ZjAzcmZrYWVOK3J4azhmTjcvT3YwMU5xQ0pnT2NITTJp?= =?utf-8?B?SHMxeVp0M0FXYTk5aW50SG80d3p3SlJvc1ArdEJuMmI4MUU4c04vd1RaZGdX?= =?utf-8?B?YWlTMnRSOWVwMzNsVU8yYit0aXlMcnF5Y3JmQ0JuTjdOd01Ud3N0S25GUkt0?= =?utf-8?B?TmU1bHNSbEpHbEJFWDA2K1RTZzQzMzVZbWx5dzluUkdsL0hZUXZBSXJFMDFn?= =?utf-8?B?VlVNa0ZqUWlJYm1WejUvZUd3U2JmOEFWKzlHVTVwcU4wVnN3Q0hxaGc0NFdK?= =?utf-8?B?SlpCMVh4Zi9JUXlJMkFuT0svbzFkQUNDSVIvV1diVGpjSVNjTlY2c3hCZ002?= =?utf-8?B?OWJ3d1UwdUkwaEFUMzY2RU91dng1NHQ5N0RpeTF3d0FSODN4NFlCRzNHR3RB?= =?utf-8?B?VUg4MXNjTTIrM2I1V0NtTFV0NW41bGFqM1BDekVHb21CRkRwMWRCVkY3blNU?= =?utf-8?B?cXVpUTBlUHpsYXRYNVJZdERzcFdpa0JkZGJOSXhUMmtqVk1WcFdreXp4Tnc3?= =?utf-8?B?VURvejRxTVlpMzF2OThMaGlDcEUxbHgrcktvdkZQTmhYTU5ya2Q0N1dRM0pM?= =?utf-8?B?U1Y3V09FTFRvTGpPenBVcGNYVFNoYkszdVQ5K1NZUGhxODlZbzQwRkNVWjlC?= =?utf-8?B?ZUs0TEFTdWt0WUQ4Z2VtVWNqUWdERUdOVXhpYlZ3RzZSbktKdFYvaWpidldo?= =?utf-8?B?WnpyUW9ZOXlxcnBGd0pqb2tYaHNBQ2ZzRnFoelI0TDNNNW9DUHRQZHlvTlJM?= =?utf-8?B?SkhpdzBLZVJCODlGSWhQU1lhMkJuR1BYMWJac2JRaEhERDF4cysxOWlOeXZi?= =?utf-8?B?TWVtdjVkRVRGaHA3ZFBaekNQN2dxbEcwTi8xREt2dlNOL09IcGszbnVsZjFv?= =?utf-8?B?dHM2SE9hOVVMYzBxUEZmWVB3UXdmMjVWRXBnNFp4a3BLTWFhOVA0cDZLOEh3?= =?utf-8?B?RHh4NDU3cStEbTlwbFE5KzdFVmt1cWYyY0VXc0M1OGpoMWFxdXh4bDltNzh1?= =?utf-8?B?Y2hjMG9LcDRhbU5lTnFqdU9OMjZOTzU0eXVVMUJ6N2lqYUVpRFIvcFgxV2w3?= =?utf-8?B?WGxYMDZ4Sjh1aTRiajB2MDc5T3BOZkROMlp2KzhEMHpzYXl3cWNOZFZSaVo3?= =?utf-8?B?MzE3NVdMald6eFVvS1d0S05KRThxUUVYdDg3R2J6NUNOYUNNTXQxT1V2ejc1?= =?utf-8?B?SkRvWURwZE0rZW9wOFFiU1FTVkVENlEzNThZTTJiOXZSclU5aXRaendWc29s?= =?utf-8?B?UzdySFhaSnFlM0NCZmR1OG92Wkp3aGZibGZHWEF1ZnlNeHJXYXJmQXh4QU9W?= =?utf-8?B?RDVrZEVNMTdrQ1hjd0taMUFSeVFYcWNvUnFiMU5sRjUwNndwMjJ1N2xqZ3hz?= =?utf-8?B?d3RmNDZhelkrb3Y3Tlp3aS9NR0lmUnppYTFpbjgzQlpmWEZHVFk0SHFDS1Y2?= =?utf-8?B?YVlOWEJtWjk2NFlKMG1CcWxsMmtFbnh3K2ZEL1VYTjFwTElTU1lqb2NzbHY3?= =?utf-8?B?SUhWNExPcUdVU1JGa3ozRWxnYllQUVhiN2VxWGk2aHp6eS95dTNWSWRSTC82?= =?utf-8?B?UEw2NDdGTGJkVFVSaFNyVnFUeXl5U1p1OWR6K3dSZUZQU1RGVEtoT1o3Z21P?= =?utf-8?B?V2ZmUWRhYUpiY2tYeDUrNnJhUlJRUldEUTVlRW1rdjd1d21SNzdjR2xyYzJK?= =?utf-8?B?Z1ZjanBlRmI1cEZvdWNiUmUxSFJudG8xQlF4MDZFNWVacHl0L0h3UTFld0pk?= =?utf-8?B?WWJ2eG03T2Zyd2I0OVpZdk41QlE3cCtTWW9ING9tTFdmcm5DNEg2SlJoclZx?= =?utf-8?B?QkZheWRVWnNYL3ZUaDZOWHdLZ21jd2xmM3J1a01mMGJZVXJjaXRBSWlzUHA2?= =?utf-8?B?ajBsOFpaNDVpeDcrUTlmYXl1aXQ2R3hlZkNiU3E4WEZHdGgyRm1EUVk3Y25p?= =?utf-8?B?L0JDVDd0aTFjZzlrODJiQWt4RmQxQ1dsY1RGWlUvQUFWN0daNVhhemRidnRp?= =?utf-8?Q?ad98O69YnROCo0rE+V7pbe2wZ?= X-MS-Exchange-CrossTenant-Network-Message-Id: b0f4cba4-9898-4224-ed5e-08db3b5478d8 X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4500.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2023 12:50:19.7048 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fbXv5raHMLvb2DmnUjamRMn6RpLxIuyucZ3B0p8PrLmxD0JG0r/ToO0O2MayVfUSRSOjSSc9wjAheQhkLRvyAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7137 X-OriginatorOrg: intel.com Received-SPF: pass client-ip=192.55.52.93; envelope-from=fei2.wu@intel.com; helo=mga11.intel.com X-Spam_score_int: -54 X-Spam_score: -5.5 X-Spam_bar: ----- X-Spam_report: (-5.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.083, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 4/11/2023 3:27 PM, Alex Bennée wrote: > > "Wu, Fei" writes: > >> On 4/10/2023 6:36 PM, Alex Bennée wrote: >>> >>> Richard Henderson writes: >>> >>>> On 4/6/23 00:46, Alex Bennée wrote: >>>>> If your aim is to examine JIT efficiency what is wrong with the current >>>>> "info jit" that you can access via the HMP? Also I'm wondering if its >>>>> time to remove the #ifdefs from CONFIG_PROFILER because I doubt the >>>>> extra data it collects is that expensive. >>>>> Richard, what do you think? >>>> >>>> What is it that you want from CONFIG_PROFILER that you can't get from perf? >>>> I've been tempted to remove CONFIG_PROFILER entirely. >>> >>> I think perf is pretty good at getting the hot paths in the translator >>> and pretty much all of the timer related stuff in CONFIG_PROFILER could >>> be dropped. However some of the additional information about TCG ops >>> usage and distribution is useful. That said last time I had a tilt at >>> this on the back of a GSoC project: >>> >>> Subject: [PATCH v9 00/13] TCG code quality tracking and perf integration >>> Date: Mon, 7 Oct 2019 16:28:26 +0100 >>> Message-Id: <20191007152839.30804-1-alex.bennee@linaro.org> >>> >>> The series ended up moving all the useful bits of CONFIG_PROFILER into >>> tb stats which was dynamically controlled on a per TB basis. Now that >>> the perf integration stuff was merged maybe there is a simpler series to >>> be picked out of the remains? >>> >>> Fei Wu, >>> >>> Have you looked at the above series? Is that gathering the sort of >>> things you need? Is this all in service of examining the translation >>> quality of hot code? >>> >> Yes, it does have what I want, I suppose this wiki is for the series: >> https://wiki.qemu.org/Features/TCGCodeQuality > > Yes. > >> >> btw, the archive seems broken and cannot show the whole series: >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg650258.html > > I have a v10 branch here: > > https://github.com/stsquad/qemu/tree/tcg/tbstats-and-perf-v10 > > I think the top two patches can be dropped on a re-base as the JIT/perf > integration is already merged. It might be a tricky re-base though. > Depends on how much churn there has been in the tree since. > I'd like to try it. Why has it not been merged upstream? Thanks, Fei. >> >> Thanks, >> Fei. >> >>>> >>>> >>>> r~ >>> >>> > >