* [Qemu-devel] [PATCH] buildsys: Move brlapi libs to per object
@ 2017-09-07 8:47 Fam Zheng
2017-09-07 17:53 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Fam Zheng @ 2017-09-07 8:47 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Marc-André Lureau
baum.o already receives the sdl cflags in its per object variable, do
the same for brlapi libs to avoid cluttering libs_softmmu.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
chardev/Makefile.objs | 1 +
configure | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/chardev/Makefile.objs b/chardev/Makefile.objs
index 52a8127606..d68e1347f9 100644
--- a/chardev/Makefile.objs
+++ b/chardev/Makefile.objs
@@ -20,5 +20,6 @@ chardev-obj-$(CONFIG_WIN32) += char-win-stdio.o
common-obj-y += msmouse.o wctablet.o testdev.o
common-obj-$(CONFIG_BRLAPI) += baum.o
baum.o-cflags := $(SDL_CFLAGS)
+baum.o-libs := $(BRLAPI_LIBS)
common-obj-$(CONFIG_SPICE) += spice.o
diff --git a/configure b/configure
index fb7e34a901..d718718cfa 100755
--- a/configure
+++ b/configure
@@ -3106,7 +3106,6 @@ int main( void ) { return brlapi__openConnection (NULL, NULL, NULL); }
EOF
if compile_prog "" "$brlapi_libs" ; then
brlapi=yes
- libs_softmmu="$brlapi_libs $libs_softmmu"
else
if test "$brlapi" = "yes" ; then
feature_not_found "brlapi" "Install brlapi devel"
@@ -5693,6 +5692,7 @@ if test "$curl" = "yes" ; then
fi
if test "$brlapi" = "yes" ; then
echo "CONFIG_BRLAPI=y" >> $config_host_mak
+ echo "BRLAPI_LIBS=$brlapi_libs" >> $config_host_mak
fi
if test "$bluez" = "yes" ; then
echo "CONFIG_BLUEZ=y" >> $config_host_mak
--
2.13.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] buildsys: Move brlapi libs to per object
2017-09-07 8:47 [Qemu-devel] [PATCH] buildsys: Move brlapi libs to per object Fam Zheng
@ 2017-09-07 17:53 ` Philippe Mathieu-Daudé
2017-09-07 21:41 ` Marc-André Lureau
2017-09-08 6:14 ` Fam Zheng
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-09-07 17:53 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: Paolo Bonzini, Marc-André Lureau
On 09/07/2017 05:47 AM, Fam Zheng wrote:
> baum.o already receives the sdl cflags in its per object variable, do
> the same for brlapi libs to avoid cluttering libs_softmmu.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> chardev/Makefile.objs | 1 +
> configure | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/chardev/Makefile.objs b/chardev/Makefile.objs
> index 52a8127606..d68e1347f9 100644
> --- a/chardev/Makefile.objs
> +++ b/chardev/Makefile.objs
> @@ -20,5 +20,6 @@ chardev-obj-$(CONFIG_WIN32) += char-win-stdio.o
> common-obj-y += msmouse.o wctablet.o testdev.o
> common-obj-$(CONFIG_BRLAPI) += baum.o
> baum.o-cflags := $(SDL_CFLAGS)
> +baum.o-libs := $(BRLAPI_LIBS)
>
> common-obj-$(CONFIG_SPICE) += spice.o
> diff --git a/configure b/configure
> index fb7e34a901..d718718cfa 100755
> --- a/configure
> +++ b/configure
> @@ -3106,7 +3106,6 @@ int main( void ) { return brlapi__openConnection (NULL, NULL, NULL); }
> EOF
> if compile_prog "" "$brlapi_libs" ; then
> brlapi=yes
> - libs_softmmu="$brlapi_libs $libs_softmmu"
> else
> if test "$brlapi" = "yes" ; then
> feature_not_found "brlapi" "Install brlapi devel"
> @@ -5693,6 +5692,7 @@ if test "$curl" = "yes" ; then
> fi
> if test "$brlapi" = "yes" ; then
> echo "CONFIG_BRLAPI=y" >> $config_host_mak
> + echo "BRLAPI_LIBS=$brlapi_libs" >> $config_host_mak
> fi
> if test "$bluez" = "yes" ; then
> echo "CONFIG_BLUEZ=y" >> $config_host_mak
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] buildsys: Move brlapi libs to per object
2017-09-07 8:47 [Qemu-devel] [PATCH] buildsys: Move brlapi libs to per object Fam Zheng
2017-09-07 17:53 ` Philippe Mathieu-Daudé
@ 2017-09-07 21:41 ` Marc-André Lureau
2017-09-08 6:14 ` Fam Zheng
2 siblings, 0 replies; 4+ messages in thread
From: Marc-André Lureau @ 2017-09-07 21:41 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, Paolo Bonzini
----- Original Message -----
> baum.o already receives the sdl cflags in its per object variable, do
> the same for brlapi libs to avoid cluttering libs_softmmu.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> chardev/Makefile.objs | 1 +
> configure | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/chardev/Makefile.objs b/chardev/Makefile.objs
> index 52a8127606..d68e1347f9 100644
> --- a/chardev/Makefile.objs
> +++ b/chardev/Makefile.objs
> @@ -20,5 +20,6 @@ chardev-obj-$(CONFIG_WIN32) += char-win-stdio.o
> common-obj-y += msmouse.o wctablet.o testdev.o
> common-obj-$(CONFIG_BRLAPI) += baum.o
> baum.o-cflags := $(SDL_CFLAGS)
> +baum.o-libs := $(BRLAPI_LIBS)
>
> common-obj-$(CONFIG_SPICE) += spice.o
> diff --git a/configure b/configure
> index fb7e34a901..d718718cfa 100755
> --- a/configure
> +++ b/configure
> @@ -3106,7 +3106,6 @@ int main( void ) { return brlapi__openConnection (NULL,
> NULL, NULL); }
> EOF
> if compile_prog "" "$brlapi_libs" ; then
> brlapi=yes
> - libs_softmmu="$brlapi_libs $libs_softmmu"
> else
> if test "$brlapi" = "yes" ; then
> feature_not_found "brlapi" "Install brlapi devel"
> @@ -5693,6 +5692,7 @@ if test "$curl" = "yes" ; then
> fi
> if test "$brlapi" = "yes" ; then
> echo "CONFIG_BRLAPI=y" >> $config_host_mak
> + echo "BRLAPI_LIBS=$brlapi_libs" >> $config_host_mak
> fi
> if test "$bluez" = "yes" ; then
> echo "CONFIG_BLUEZ=y" >> $config_host_mak
> --
> 2.13.5
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] buildsys: Move brlapi libs to per object
2017-09-07 8:47 [Qemu-devel] [PATCH] buildsys: Move brlapi libs to per object Fam Zheng
2017-09-07 17:53 ` Philippe Mathieu-Daudé
2017-09-07 21:41 ` Marc-André Lureau
@ 2017-09-08 6:14 ` Fam Zheng
2 siblings, 0 replies; 4+ messages in thread
From: Fam Zheng @ 2017-09-08 6:14 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Marc-André Lureau
On Thu, 09/07 16:47, Fam Zheng wrote:
> baum.o already receives the sdl cflags in its per object variable, do
> the same for brlapi libs to avoid cluttering libs_softmmu.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
Thanks, I'll send a pull request later.
Fam
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-08 6:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-07 8:47 [Qemu-devel] [PATCH] buildsys: Move brlapi libs to per object Fam Zheng
2017-09-07 17:53 ` Philippe Mathieu-Daudé
2017-09-07 21:41 ` Marc-André Lureau
2017-09-08 6:14 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).