From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60B4DCAC587 for ; Tue, 9 Sep 2025 09:41:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uvupe-0003kc-HT; Tue, 09 Sep 2025 05:40:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvupb-0003kI-BO for qemu-devel@nongnu.org; Tue, 09 Sep 2025 05:40:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uvupV-0001hH-B4 for qemu-devel@nongnu.org; Tue, 09 Sep 2025 05:40:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757410797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=X4Qf2orAU4ARmGVy+m+UbJbeiWFJZSC4OwewZEIoWE4=; b=Uhba9L76N0/i2baYNp0eKVKAgp3mCqIYsSwH8RwDJC8NQDETUNWQ9ZDBXtLRFA/eMdkWxv eGLuImwdayTNIat1Xd4hbcgUxtN12UT9Zd+kCSM984XzNTtp/h66cVd83wmdbjLPybrpvc o42/y+yoKm4/0YmnE28V5ia8tvm7Q3o= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-614-gwwmbH7mNMWSW0kDKLqspA-1; Tue, 09 Sep 2025 05:39:55 -0400 X-MC-Unique: gwwmbH7mNMWSW0kDKLqspA-1 X-Mimecast-MFC-AGG-ID: gwwmbH7mNMWSW0kDKLqspA_1757410795 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3e61deaf253so2103285f8f.1 for ; Tue, 09 Sep 2025 02:39:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757410794; x=1758015594; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=X4Qf2orAU4ARmGVy+m+UbJbeiWFJZSC4OwewZEIoWE4=; b=Yrkwpy/p8kvLA3mLzOljG0VFyJRzeFW8l2zfTQ815E2+Pd0yoOhncJfBbfrYN35XSx pKPGiUneoYpSVsLvL8DRmqKgsayyQLSHqjUN0w0thAGdrACuEz0faH6Sr9cjLvLRMUU0 irMIzzovqqI7gbAnxlyP3IJ44H0o4oPj9b9v/ZH2a3609yYUIutKygrTD5O08dc+j1SL k62EKNgOD4tnbjNPw+CQXoAm/rjwLa+jQ/739xakCh3/n/G26bLZIR8dxtQYCTM63uLw XOQE4OY5ZqnhQWsGQGF1jsi67y4Fc6DqPlkI2AoLCKtOFUFVh3UgTGm1+4RxJQ/NbYh7 EPdA== X-Forwarded-Encrypted: i=1; AJvYcCXypehP3L57obRHyOyzNdsQJp4t9rJwL6Gs5eiwQehkzXcNP2EDKWdhchXf4eUIjvsh5aYhinPlWz+y@nongnu.org X-Gm-Message-State: AOJu0YwBxsk0GoQbeUS1634+wgWwlzakYmCIiga7QpseSWmQX/mTPYMb hvF0VrBSMP9tsc/nIUiqdzsKnpbDmKXw0hzuyUsuxma496E4LHsxFu7ATaC4DLc7ghyjCbbAwms RXs+H6z8hy2jhnrHwqpkDkjTPX0lxybcJQgQ5FTtC+D86Nwtr/nemUmllzJBAmqTWHNc= X-Gm-Gg: ASbGncsK8iiD2WDkHYg1JZc6fVOv2bBAhHFlHj0VvWWgPpOgNu5ooTKrhLrLuOGrNmZ tAvZFqxaFYSFtqdAFtJO93mt3qxThfZ1rX9hb+ndJ5Tg4vU7MMPuCcjP6ln9hQDIiyQwWTCf80L R4s7ALSVrGNHNXnHilz0kOmur9FiY6a+k1wsjzJc+mjcYzvQAuG1HSeWtF8kM9O6s8H02poF4WU DPJWROXzrhYyNejJ/EzFc26OLfa3J6oTddoQwoFzjWNhqhDD4AqTRpCr7OhbziZLMtq9Ab1cPeW 5iLZP3jYSHUEvxy+m/T3GQxoy4irlflJWLxl3pwqY7Uklk1MSiDkqBo625zWTcfqtnXKd2olOI3 kem158Q== X-Received: by 2002:a05:6000:2203:b0:3dc:3b91:6231 with SMTP id ffacd0b85a97d-3e636d8f8demr8393445f8f.12.1757410794517; Tue, 09 Sep 2025 02:39:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGYNwAZysS+1TYd4P8B7I9ygKDgPFlUQI2/QZshIgzLNkEDWyazfJzC8DQUvhtZODgjeJw2Zg== X-Received: by 2002:a05:6000:2203:b0:3dc:3b91:6231 with SMTP id ffacd0b85a97d-3e636d8f8demr8393429f8f.12.1757410794043; Tue, 09 Sep 2025 02:39:54 -0700 (PDT) Received: from [192.168.0.7] (ltea-047-064-113-183.pools.arcor-ip.net. [47.64.113.183]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3e7521ca0e9sm2006099f8f.25.2025.09.09.02.39.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Sep 2025 02:39:53 -0700 (PDT) Message-ID: <205bdbb5-19b4-4b00-8554-d3d9c7510613@redhat.com> Date: Tue, 9 Sep 2025 11:39:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/22] target/mips: Fix AddressSpace exposure timing To: Akihiko Odaki , qemu-devel@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= Cc: Alex Williamson , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Paolo Bonzini , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Eduardo Habkost , Peter Xu , David Hildenbrand , Richard Henderson , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , "Michael S. Tsirkin" , Gerd Hoffmann , Keith Busch , Klaus Jensen , Jesper Devantier , Nicholas Piggin , John Levon , Thanos Makatos , Yanan Wang , Jiaxun Yang , Daniel Henrique Barboza , David Gibson , Harsh Prateek Bora , =?UTF-8?Q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Laurent Vivier , Peter Maydell , =?UTF-8?Q?Herv=C3=A9_Poussineau?= , Mark Cave-Ayland , Artyom Tarasenko References: <20250906-use-v1-0-c51caafd1eb7@rsg.ci.i.u-tokyo.ac.jp> <20250906-use-v1-4-c51caafd1eb7@rsg.ci.i.u-tokyo.ac.jp> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20250906-use-v1-4-c51caafd1eb7@rsg.ci.i.u-tokyo.ac.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 06/09/2025 04.11, Akihiko Odaki wrote: > mips-cpu is not hotpluggable but its instance can still be created and > finalized when processing the device-list-properties QMP command. > Exposing such a temporary instance to AddressSpace should be > avoided because it leaks the instance. > > Expose instances to the AddressSpace at their realization time so that > it won't happen for the temporary instances. > > Signed-off-by: Akihiko Odaki > --- > target/mips/cpu.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/target/mips/cpu.c b/target/mips/cpu.c > index 1f6c41fd3401e88637c2c0d8fe3fcf4a38370288..e166b570984a40fba2ef417799a267eac9bff7d3 100644 > --- a/target/mips/cpu.c > +++ b/target/mips/cpu.c > @@ -457,6 +457,13 @@ static void mips_cpu_realizefn(DeviceState *dev, Error **errp) > MIPSCPUClass *mcc = MIPS_CPU_GET_CLASS(dev); > Error *local_err = NULL; > > +#ifndef CONFIG_USER_ONLY > + if (mcc->cpu_def->lcsr_cpucfg2 & (1 << CPUCFG2_LCSRP)) { > + address_space_init(&env->iocsr.as, > + &env->iocsr.mr, "IOCSR"); > + } > +#endif > + > if (!clock_get(cpu->clock)) { > #ifndef CONFIG_USER_ONLY > if (!qtest_enabled()) { > @@ -505,8 +512,6 @@ static void mips_cpu_initfn(Object *obj) > if (mcc->cpu_def->lcsr_cpucfg2 & (1 << CPUCFG2_LCSRP)) { > memory_region_init_io(&env->iocsr.mr, OBJECT(cpu), NULL, > env, "iocsr", UINT64_MAX); > - address_space_init(&env->iocsr.as, > - &env->iocsr.mr, "IOCSR"); > } > #endif > } > Reviewed-by: Thomas Huth