From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A83DC43464 for ; Fri, 18 Sep 2020 09:53:23 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94A6A21D20 for ; Fri, 18 Sep 2020 09:53:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hFp5IJIP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94A6A21D20 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJD4z-0000Ml-KN for qemu-devel@archiver.kernel.org; Fri, 18 Sep 2020 05:53:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJD4O-0008Il-Po for qemu-devel@nongnu.org; Fri, 18 Sep 2020 05:52:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:30294) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kJD4N-0008Dv-Da for qemu-devel@nongnu.org; Fri, 18 Sep 2020 05:52:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600422761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EUXXs9VDvT0gu1zX9dEuHcsAWpPbUe/gqbdle9pook8=; b=hFp5IJIP4Ue0FGFkIVF9rmpy3Ta0BrXFFTgvKHFLTurM+z43rSiQxlWb3QwPNgFSB4p+PR GCzMsqYIAuGXSJ5XYh7Xbn9ASEgCnZJkQ1HNNyliMC7hyI6xkEWwedvE/4cTx9k242JrzF v5b+WE0tu6jvQg2v65pIhFmWsPKb5ng= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-246-77dZw9uBNBWfO2DyLherWw-1; Fri, 18 Sep 2020 05:52:37 -0400 X-MC-Unique: 77dZw9uBNBWfO2DyLherWw-1 Received: by mail-wm1-f71.google.com with SMTP id b14so1288424wmj.3 for ; Fri, 18 Sep 2020 02:52:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=EUXXs9VDvT0gu1zX9dEuHcsAWpPbUe/gqbdle9pook8=; b=q5+ICa6T9o9yw1Bm/zPhPJAp76u5dWP478iu2MVfm4RgNvvzn/lUoCGfnXIaBlhkPg hH1l38mIIw9w40pZRBe9NiZN5TSUhniN6QntV1W94SOUXpn5GOmYWbXVxc/LXgK1Nzpb PcPdd+SDw/Ws3wCZJ4asDlaCPUykzQdlkZtjPgLuyWmQJ6JgYzyAyFpZAFwFKWv3DtEa 7WN/5Ug+L0gERgzO7o9IDQaIxyoTYrAIWfkbTgZ6SEMXIIbexNQVRKjyvyZpuhhz2ED+ pLn8GLoFYbIrOcD61fg0aSyT0iEFj1Ta980iKcSS7ZpbnrwOIG7+pHGJ1o+fSF9Fk38m AvhQ== X-Gm-Message-State: AOAM5300HqD0s1ZR+be952MdLw02qK10KNcZllqmmqTrtvyS8GA4qKCJ oxFspwqL1YdseXyqFL2pKcUvnDGMGSob1bHrpJ2QRmAjJTu08UZ/om/2ja15zlA2ccyYtDvrnsd vZBCyTo/41XjilOY= X-Received: by 2002:adf:f082:: with SMTP id n2mr36403067wro.35.1600422756680; Fri, 18 Sep 2020 02:52:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCzwA2nKuXZuetC/RMzAI/tjNa/tyNH0pzGoo/PGDl+n3aOso2f2bZRO3XvxnbQp3EEXJ/kA== X-Received: by 2002:adf:f082:: with SMTP id n2mr36403050wro.35.1600422756483; Fri, 18 Sep 2020 02:52:36 -0700 (PDT) Received: from [192.168.1.36] (65.red-83-57-170.dynamicip.rima-tde.net. [83.57.170.65]) by smtp.gmail.com with ESMTPSA id n3sm3959297wmn.39.2020.09.18.02.52.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Sep 2020 02:52:35 -0700 (PDT) Subject: Re: [PATCH] util: include the target address in socket connect failures To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-devel@nongnu.org References: <20200918093436.1775120-1-berrange@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <205ca5cf-3833-05cd-c2bf-d6e5d6bad1ca@redhat.com> Date: Fri, 18 Sep 2020 11:52:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200918093436.1775120-1-berrange@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/18 00:20:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.997, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Gerd Hoffmann , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/18/20 11:34 AM, Daniel P. Berrangé wrote: > Reporting "Failed to connect socket" is essentially useless for a user > attempting to diagnose failure. It needs to include the target addres > details. Simiarly when failing to create a socket we should include the Typos "address", "Similarly". > socket family info, so the user understands what particular feature was > missing in their kernel build (IPv6, VSock in particular). > > Signed-off-by: Daniel P. Berrangé > --- > tests/qemu-iotests/162.out | 4 ++-- > util/qemu-sockets.c | 32 +++++++++++++++++++------------- > 2 files changed, 21 insertions(+), 15 deletions(-) Reviewed-by: Philippe Mathieu-Daudé