Re: [Qemu-devel] PATCH: fix bgr color mapping on qemu on Solaris/SPARC

[Ben Taylor <sol10x86@cox.net>]

---- Fabrice Bellard <fabrice@bellard.org> wrote: 
> In order to stop the release of incomplete BGR patches, I am 
> implementing a more complete patch. I am just adding depth = 32 with BGR 
> instead of RGB. If other pixel formats are wanted, you should signal it now.

I added an "int bgr;" to the displaystruct in vl.h, but that is now causing a core dump
upon starting qemu with the rest of your patch.

here's the back trace:

#0  0x00033204 in console_show_cursor (s=0x11f95bd8, show=301554760) at vl.h:692
#1  0x0003373c in console_puts (chr=0x36, buf=0x140c18 "QEMU 0.8.1 monitor - type 'help' for more information\n", len=54)
    at /export/src/qemu/May10-V2/qemu-solaris/console.c:825
#2  0x00024eb8 in qemu_chr_write (s=0x36, buf=0x140c18 "QEMU 0.8.1 monitor - type 'help' for more information\n", len=54)
    at /export/src/qemu/May10-V2/qemu-solaris/vl.c:1096
#3  0x0002d208 in term_flush () at /export/src/qemu/May10-V2/qemu-solaris/monitor.c:72
#4  0x0002d27c in term_puts (str=0xffbfb78e "") at /export/src/qemu/May10-V2/qemu-solaris/monitor.c:88
#5  0x0002d2d0 in term_vprintf (fmt=0xfcd68 "QEMU %s monitor - type 'help' for more information\n", ap=0xffbfc820)
    at /export/src/qemu/May10-V2/qemu-solaris/monitor.c:96
#6  0x0002d304 in term_printf (fmt=0xfcd68 "QEMU %s monitor - type 'help' for more information\n")
    at /export/src/qemu/May10-V2/qemu-solaris/monitor.c:103
#7  0x00030470 in monitor_init (hd=0x11f82f38, show_banner=1) at /export/src/qemu/May10-V2/qemu-solaris/monitor.c:2288
#8  0x00029804 in main (argc=7, argv=0xffbff33c) at /export/src/qemu/May10-V2/qemu-solaris/vl.c:5658


Ideas?

Ben