From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA766C433DF for ; Sun, 26 Jul 2020 17:19:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A40C2065F for ; Sun, 26 Jul 2020 17:19:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=crudebyte.com header.i=@crudebyte.com header.b="WhMdZ6Ak" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A40C2065F Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=crudebyte.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzkJR-00016a-Q7 for qemu-devel@archiver.kernel.org; Sun, 26 Jul 2020 13:19:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jzkIr-0000fj-Ln for qemu-devel@nongnu.org; Sun, 26 Jul 2020 13:19:13 -0400 Received: from lizzy.crudebyte.com ([91.194.90.13]:43523) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jzkIn-0007Qp-SR for qemu-devel@nongnu.org; Sun, 26 Jul 2020 13:19:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=lizzy; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Content-ID:Content-Description; bh=Z+vJm6SOxrPPUAbIlCJdSlZ1CBxbqKvoUJH1PfLlFp4=; b=WhMdZ6AkFTwUqME5oRrztLKQgZ JwKEnw2syoUNE1xXwEuAQBJxGxDw8BH8wCNifz5WofkFDS0c9kHQgNsojzOBy/TMKGF0wtGf4DRCj w92GlhfO/75f+ivUhcZcb5ng3hIsljqH2NWR6DVLYDbsS8uAMoulw7AKTAVEg7xQl8lKBo17pIXh/ yEqD/EGTlSl9XXG9MpxoKIrzGebQE5hPe4AOFaUSP3cxQCWlsNpzeU6OBjFuyifk+UkVVMgqrvX6S 9WJ0lofLkUf3WE59legf2+IwbgJ/m/KEsSdq23GYlc+el1hgqzCEdv5WJgPON0il0TCmj6v6leTHI O+qPkpAA==; From: Christian Schoenebeck To: qemu-devel@nongnu.org Cc: Ed Maste , Thomas Huth , Peter Maydell , Paolo Bonzini , Alex =?ISO-8859-1?Q?Benn=E9e?= , Li-Wen Hsu , Richard Henderson Subject: Re: [PATCH 2/3] cirrus.yml: Compile macOS and FreeBSD with -Werror Date: Sun, 26 Jul 2020 19:19:03 +0200 Message-ID: <2063507.Rj2kWPf9UF@silver> In-Reply-To: References: <20200724143220.32751-1-thuth@redhat.com> <20200724143220.32751-3-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: pass client-ip=91.194.90.13; envelope-from=qemu_oss@crudebyte.com; helo=lizzy.crudebyte.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/26 13:19:06 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sonntag, 26. Juli 2020 18:14:11 CEST Ed Maste wrote: > On Fri, 24 Jul 2020 at 10:32, Thomas Huth wrote: > > Compiler warnings currently go unnoticed in our FreeBSD and macOS builds, > > since -Werror is only enabled for Linux and MinGW builds by default. So > > let's enable them here now, too. > > Reviewed-by: Ed Maste > > for the FreeBSD change; I'm indifferent on which method is used to > address the macos deprecation warnings. Like I pointed out on my response to Peter, it is a bit risky to just blindly link against Apple's version of sasl on macOS. Say you compile qemu on a certain macOS version, then you run qemu again after an update of macOS without recompiling qemu, chances are that you get misbehaviours. One solution would be bundling the qemu app along with sasl, so qemu would be forced to use that bundled sasl version instead of whatever Apple's version of sasl is installed on the system. Another appraoch would be checking the system's sasl version on qemu startup by calling either sasl_version() or sasl_version_info() and comparing that with the version qemu was compiled with, and erroring out on doubt. Or obvious last option: simply taking the risk by ignoring this potential issue. The SASL headers are still made available by Apple, which suggests that they don't break SASL 'too often'. Your choice. ;-) Best regards, Christian Schoenebeck