From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, pbonzini@redhat.com, qemu-block@nongnu.org,
mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v6 00/15] nbd: efficient write zeroes
Date: Fri, 14 Oct 2016 09:19:46 -0500 [thread overview]
Message-ID: <20655960-5852-f24c-1cb6-157e4579dae9@redhat.com> (raw)
In-Reply-To: <20161014045928.502016.13794@ex-std-node742.prod.rhcloud.com>
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
On 10/13/2016 11:59 PM,
no-reply@ec2-52-6-146-230.compute-1.amazonaws.com wrote:
> Checking PATCH 13/15: nbd: Improve server handling of shutdown requests...
> ERROR: return of an errno should typically be -ve (return -ESHUTDOWN)
> #63: FILE: nbd/client.c:38:
> + return ESHUTDOWN;
>
> total: 1 errors, 0 warnings, 95 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
False positive; although we COULD rewrite the function to do:
ret = ESHUTDOWN;
return ret;
(and so on for all the cases in the switch), to hide the fact that we
intentionally want to return a positive errno value, if it bothers
anyone enough to ask me to do so.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2016-10-14 14:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 20:58 [Qemu-devel] [PATCH v6 00/15] nbd: efficient write zeroes Eric Blake
2016-10-13 20:58 ` [Qemu-devel] [PATCH v6 01/15] nbd: Add qemu-nbd -D for human-readable description Eric Blake
2016-10-13 20:58 ` [Qemu-devel] [PATCH v6 02/15] nbd: Treat flags vs. command type as separate fields Eric Blake
2016-10-13 20:58 ` [Qemu-devel] [PATCH v6 03/15] nbd: Rename NBDRequest to NBDRequestData Eric Blake
2016-10-13 20:58 ` [Qemu-devel] [PATCH v6 04/15] nbd: Rename NbdClientSession to NBDClientSession Eric Blake
2016-10-13 20:58 ` [Qemu-devel] [PATCH v6 05/15] nbd: Rename struct nbd_request and nbd_reply Eric Blake
2016-10-13 20:58 ` [Qemu-devel] [PATCH v6 06/15] nbd: Share common reply-sending code in server Eric Blake
2016-10-13 20:58 ` [Qemu-devel] [PATCH v6 07/15] nbd: Send message along with server NBD_REP_ERR errors Eric Blake
2016-10-13 20:58 ` [Qemu-devel] [PATCH v6 08/15] nbd: Share common option-sending code in client Eric Blake
2016-10-13 20:58 ` [Qemu-devel] [PATCH v6 09/15] nbd: Let server know when client gives up negotiation Eric Blake
2016-10-13 20:58 ` [Qemu-devel] [PATCH v6 10/15] nbd: Let client skip portions of server reply Eric Blake
2016-10-13 20:58 ` [Qemu-devel] [PATCH v6 11/15] nbd: Less allocation during NBD_OPT_LIST Eric Blake
2016-10-13 20:58 ` [Qemu-devel] [PATCH v6 12/15] nbd: Support shorter handshake Eric Blake
2016-10-13 20:58 ` [Qemu-devel] [PATCH v6 13/15] nbd: Improve server handling of shutdown requests Eric Blake
2016-10-13 20:58 ` [Qemu-devel] [PATCH v6 14/15] nbd: Implement NBD_CMD_WRITE_ZEROES on server Eric Blake
2016-10-13 20:58 ` [Qemu-devel] [PATCH v6 15/15] nbd: Implement NBD_CMD_WRITE_ZEROES on client Eric Blake
2016-10-14 0:00 ` [Qemu-devel] [PATCH v6 00/15] nbd: efficient write zeroes no-reply
2016-10-14 2:06 ` Eric Blake
2016-10-14 4:59 ` no-reply
2016-10-14 14:19 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20655960-5852-f24c-1cb6-157e4579dae9@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).