From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bv3L8-0008Lh-Iw for qemu-devel@nongnu.org; Fri, 14 Oct 2016 10:20:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bv3L4-0002xl-3p for qemu-devel@nongnu.org; Fri, 14 Oct 2016 10:20:02 -0400 References: <20161014045928.502016.13794@ex-std-node742.prod.rhcloud.com> From: Eric Blake Message-ID: <20655960-5852-f24c-1cb6-157e4579dae9@redhat.com> Date: Fri, 14 Oct 2016 09:19:46 -0500 MIME-Version: 1.0 In-Reply-To: <20161014045928.502016.13794@ex-std-node742.prod.rhcloud.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9cgvc9BSdkQWMe8KUjltcq1VAF2M0nuIJ" Subject: Re: [Qemu-devel] [PATCH v6 00/15] nbd: efficient write zeroes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: famz@redhat.com, pbonzini@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9cgvc9BSdkQWMe8KUjltcq1VAF2M0nuIJ From: Eric Blake To: qemu-devel@nongnu.org Cc: famz@redhat.com, pbonzini@redhat.com, qemu-block@nongnu.org, mreitz@redhat.com Message-ID: <20655960-5852-f24c-1cb6-157e4579dae9@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 00/15] nbd: efficient write zeroes References: <20161014045928.502016.13794@ex-std-node742.prod.rhcloud.com> In-Reply-To: <20161014045928.502016.13794@ex-std-node742.prod.rhcloud.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/13/2016 11:59 PM, no-reply@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > Checking PATCH 13/15: nbd: Improve server handling of shutdown requests= =2E.. > ERROR: return of an errno should typically be -ve (return -ESHUTDOWN) > #63: FILE: nbd/client.c:38: > + return ESHUTDOWN; >=20 > total: 1 errors, 0 warnings, 95 lines checked >=20 > Your patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. False positive; although we COULD rewrite the function to do: ret =3D ESHUTDOWN; return ret; (and so on for all the cases in the switch), to hide the fact that we intentionally want to return a positive errno value, if it bothers anyone enough to ask me to do so. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9cgvc9BSdkQWMe8KUjltcq1VAF2M0nuIJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYAOmCAAoJEKeha0olJ0NqTNgH/RJZ6OX9XYB5aW+W0I2OYRFh uGOXf3ioo2ZRs8ed1dj6TILgFZUY3ybjneAeSCNPH8PG+g0DJRtKBqcE91v/cClN DLrT718xCbbnNYMtTI+XHQgxWBCrZPW9YI9q7E5EiZTfmKEuWyfCyoqns7+B0CX4 yVNLDVqE1Rym/SQmNOJwS60hbUSX7s+fQNM4RnD+mgJbymaiugGATX0BTkC1V+X1 JhmbVnjo5cLtoKduZ3pQDCZKCI3P8R721fQnv5SyoLCH7HUi6Yq1d882HV+y2t9k DOpr8/a7OSb+QqPLSZMw6Py4TFXo67ulDd6KR/DZdCKBxSbZVbSuIZK5P0LLr/M= =9QE3 -----END PGP SIGNATURE----- --9cgvc9BSdkQWMe8KUjltcq1VAF2M0nuIJ--