Re: [PATCH 1/7] target/hppa: ldcw,s uses static shift of 3

[Richard Henderson <richard.henderson@linaro.org>]

On 3/17/24 12:14, Sven Schnelle wrote:
> Signed-off-by: Sven Schnelle <svens@stackframe.org>
> ---
>   target/hppa/translate.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/hppa/translate.c b/target/hppa/translate.c
> index eb2046c5ad..6a513d7d5c 100644
> --- a/target/hppa/translate.c
> +++ b/target/hppa/translate.c
> @@ -3085,7 +3085,7 @@ static bool trans_ldc(DisasContext *ctx, arg_ldst *a)
>           dest = dest_gpr(ctx, a->t);
>       }
>   
> -    form_gva(ctx, &addr, &ofs, a->b, a->x, a->scale ? a->size : 0,
> +    form_gva(ctx, &addr, &ofs, a->b, a->x, a->scale ? 3 : 0,
>                a->disp, a->sp, a->m, MMU_DISABLED(ctx));
>   
>       /*

Whoops, broken since day one.

Fixes: 96d6407f363 ("target-hppa: Implement loads and stores")
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~