Re: [Qemu-devel] [PATCH 2/4] qmp-shell: ignore query-commands error

["Marc-André Lureau" <marcandre.lureau@redhat.com>]

Hi

----- Original Message -----
> I'd like to rephrase "ignore query-commands error" to "Cope with
> query-commands error" on commit, if you don't mind.
> 

No, please do :)
thanks

> Marc-André Lureau <marcandre.lureau@redhat.com> writes:
> 
> > qemu-ga doesn't implement it.
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> >  scripts/qmp/qmp-shell | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell
> > index f80d02312a..04b8fa3eae 100755
> > --- a/scripts/qmp/qmp-shell
> > +++ b/scripts/qmp/qmp-shell
> > @@ -126,7 +126,10 @@ class QMPShell(qmp.QEMUMonitorProtocol):
> >          return arg
> >  
> >      def _fill_completion(self):
> > -        for cmd in self.cmd('query-commands')['return']:
> > +        cmds = self.cmd('query-commands')
> > +        if cmds.has_key('error'):
> > +            return
> > +        for cmd in cmds['return']:
> >              self._completer.append(cmd['name'])
> >  
> >      def __completer_setup(self):
>