From: Eric Blake <eblake@redhat.com>
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, vsementsov@virtuozzo.com,
qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH v11 00/11] iotests: Dump QCOW2 dirty bitmaps metadata
Date: Thu, 23 Jul 2020 14:42:08 -0500 [thread overview]
Message-ID: <20743b55-8eeb-3cac-86db-eab8c2bcd4ea@redhat.com> (raw)
In-Reply-To: <1594973699-781898-1-git-send-email-andrey.shinkevich@virtuozzo.com>
On 7/17/20 3:14 AM, Andrey Shinkevich wrote:
> Add dirty bitmap information to QCOW2 metadata dump in the qcow2_format.py.
>
> v10:
> 01: Fixing of issues in QCOW2 extension classes noted by Vladimir.
> 02: Reading bitmap tables was moved into Qcow2BitmapTable class.
> 03: Handling '-j' key was moved into "if __name__" section.
> 04: Making copy of __dict__ was replaced with the method to_dict().
> 05: Qcow2HeaderExtensionsDoc is introduced in the separate patch.
>
> Andrey Shinkevich (11):
> qcow2: Fix capitalization of header extension constant.
> qcow2_format.py: make printable data an extension class member
> qcow2_format.py: change Qcow2BitmapExt initialization method
> qcow2_format.py: dump bitmap flags in human readable way.
> qcow2_format.py: Dump bitmap directory information
> qcow2_format.py: pass cluster size to substructures
> qcow2_format.py: Dump bitmap table serialized entries
> qcow2.py: Introduce '-j' key to dump in JSON format
> qcow2_format.py: collect fields to dump in JSON format
> qcow2_format.py: introduce Qcow2HeaderExtensionsDoc class
> qcow2_format.py: support dumping metadata in JSON format
>
> block/qcow2.c | 2 +-
> docs/interop/qcow2.txt | 2 +-
> tests/qemu-iotests/qcow2.py | 18 ++-
> tests/qemu-iotests/qcow2_format.py | 221 ++++++++++++++++++++++++++++++++++---
> 4 files changed, 220 insertions(+), 23 deletions(-)
I still don't see any obvious coverage of the new output, which makes it
harder to test (I have to manually run qcow2.py on a file rather than
seeing what changes in a ???.out file). I know we said back in v9 that
test 291 is not the right test, but that does not stop you from adding a
new test just for that purpose.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-07-23 19:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 8:14 [PATCH v11 00/11] iotests: Dump QCOW2 dirty bitmaps metadata Andrey Shinkevich
2020-07-17 8:14 ` [PATCH v11 01/11] qcow2: Fix capitalization of header extension constant Andrey Shinkevich
2020-07-23 19:46 ` Eric Blake
2020-07-17 8:14 ` [PATCH v11 02/11] qcow2_format.py: make printable data an extension class member Andrey Shinkevich
2020-07-17 8:14 ` [PATCH v11 03/11] qcow2_format.py: change Qcow2BitmapExt initialization method Andrey Shinkevich
2020-07-28 9:39 ` Vladimir Sementsov-Ogievskiy
2020-07-17 8:14 ` [PATCH v11 04/11] qcow2_format.py: dump bitmap flags in human readable way Andrey Shinkevich
2020-07-17 8:14 ` [PATCH v11 05/11] qcow2_format.py: Dump bitmap directory information Andrey Shinkevich
2020-07-17 8:14 ` [PATCH v11 06/11] qcow2_format.py: pass cluster size to substructures Andrey Shinkevich
2020-07-17 8:14 ` [PATCH v11 07/11] qcow2_format.py: Dump bitmap table serialized entries Andrey Shinkevich
2020-07-28 10:02 ` Vladimir Sementsov-Ogievskiy
2020-07-17 8:14 ` [PATCH v11 08/11] qcow2.py: Introduce '-j' key to dump in JSON format Andrey Shinkevich
2020-07-28 10:07 ` Vladimir Sementsov-Ogievskiy
2020-07-17 8:14 ` [PATCH v11 09/11] qcow2_format.py: collect fields " Andrey Shinkevich
2020-07-28 11:09 ` Vladimir Sementsov-Ogievskiy
2020-07-29 5:56 ` Andrey Shinkevich
2020-08-05 7:49 ` Vladimir Sementsov-Ogievskiy
2020-07-17 8:14 ` [PATCH v11 10/11] qcow2_format.py: introduce Qcow2HeaderExtensionsDoc class Andrey Shinkevich
2020-07-28 11:36 ` Vladimir Sementsov-Ogievskiy
2020-07-28 13:27 ` Andrey Shinkevich
2020-07-28 14:05 ` Vladimir Sementsov-Ogievskiy
2020-07-30 14:11 ` Andrey Shinkevich
2020-07-30 14:24 ` Andrey Shinkevich
2020-07-17 8:14 ` [PATCH v11 11/11] qcow2_format.py: support dumping metadata in JSON format Andrey Shinkevich
2020-07-28 12:37 ` Vladimir Sementsov-Ogievskiy
2020-07-23 19:42 ` Eric Blake [this message]
2020-07-23 20:18 ` [PATCH v11 00/11] iotests: Dump QCOW2 dirty bitmaps metadata Eric Blake
2020-07-24 10:50 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20743b55-8eeb-3cac-86db-eab8c2bcd4ea@redhat.com \
--to=eblake@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).