qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <mlureau@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: marcandre lureau <marcandre.lureau@redhat.com>,
	qemu-devel@nongnu.org, peter maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PULL 00/48] ivshmem series
Date: Wed, 7 Oct 2015 08:16:40 -0400 (EDT)	[thread overview]
Message-ID: <2075219250.26126659.1444220200013.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <56150BE8.8020405@suse.de>


Hi Andreas

----- Original Message -----
> Am 06.10.2015 um 21:18 schrieb marcandre.lureau@redhat.com:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> > 
> > The following changes since commit
> > 5fdb4671b08e0d1631447e81348b2b50a6b85bf7:
> > 
> >   Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request'
> >   into staging (2015-10-06 13:42:33 +0100)
> > 
> > are available in the git repository at:
> > 
> >   https://github.com/elmarco/qemu tags/ivshmem-series
> > 
> > for you to fetch changes up to 097cadb155ef22be286af1403240b4fbf0f038ef:
> > 
> >   ivshmem: use little-endian int64_t for the protocol (2015-10-06 21:17:22
> >   +0200)
> > 
> > ----------------------------------------------------------------
> > Ivshmem series
> > 
> > ----------------------------------------------------------------
> [...]
> > Marc-André Lureau (45):
> [...]
> >       tests: add ivshmem qtest
> 
> I had NAK'ed this patch in v1 and it has not been fixed. If this pull
> gets merged I will immediately revert it. Not funny.
> 


Could stick to technical review, please. The test runs fine without kvm. Regarding your copyright claim, I already explain that your older version of boilerplate test is really nothing compare to this one. But if you feel so strongly about it, I don't care you add a copyright line.

  reply	other threads:[~2015-10-07 12:16 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-06 19:18 [Qemu-devel] [PULL 00/48] ivshmem series marcandre.lureau
2015-10-06 19:18 ` [Qemu-devel] [PULL 01/48] char: add qemu_chr_free() marcandre.lureau
2015-10-06 19:18 ` [Qemu-devel] [PULL 02/48] msix: add VMSTATE_MSIX_TEST marcandre.lureau
2015-10-06 19:18 ` [Qemu-devel] [PULL 03/48] ivhsmem: read do not accept more than sizeof(long) marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 04/48] ivshmem: fix number of bytes to push to fifo marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 05/48] ivshmem: factor out the incoming fifo handling marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 06/48] ivshmem: remove unnecessary dup() marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 07/48] ivshmem: remove superflous ivshmem_attr field marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 08/48] ivshmem: remove useless doorbell field marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 09/48] ivshmem: more qdev conversion marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 10/48] ivshmem: remove last exit(1) marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 11/48] ivshmem: limit maximum number of peers to G_MAXUINT16 marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 12/48] ivshmem: simplify around increase_dynamic_storage() marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 13/48] ivshmem: allocate eventfds in resize_peers() marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 14/48] ivshmem: remove useless ivshmem_update_irq() val argument marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 15/48] ivshmem: initialize max_peer to -1 marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 16/48] ivshmem: remove max_peer field marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 17/48] ivshmem: improve debug messages marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 18/48] ivshmem: improve error handling marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 19/48] ivshmem: print error on invalid peer id marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 20/48] ivshmem: simplify a bit the code marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 21/48] ivshmem: use common return marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 22/48] ivshmem: use common is_power_of_2() marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 23/48] ivshmem: migrate with VMStateDescription marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 24/48] ivshmem: shmfd can be 0 marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 25/48] ivshmem: check shm isn't already initialized marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 26/48] ivshmem: add device description marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 27/48] ivshmem: fix pci_ivshmem_exit() marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 28/48] ivshmem: replace 'guest' for 'peer' appropriately marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 29/48] ivshmem: error on too many eventfd received marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 30/48] ivshmem: reset mask on device reset marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 31/48] contrib: add ivshmem client and server marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 32/48] ivshmem-client: check the number of vectors marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 33/48] ivshmem-server: use a uint16 for client ID marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 34/48] ivshmem-server: fix hugetlbfs support marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 35/48] docs: update ivshmem device spec marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 36/48] ivshmem: add check on protocol version in QEMU marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 37/48] contrib: remove unnecessary strdup() marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 38/48] msix: implement pba write (but read-only) marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 39/48] qtest: add qtest_add_abrt_handler() marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 40/48] glib-compat: add 2.38/2.40/2.46 asserts marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 41/48] tests: add ivshmem qtest marcandre.lureau
2015-10-10 21:29   ` Michael Roth
2015-10-12 13:53     ` Marc-André Lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 42/48] ivshmem: do not keep shm_fd open marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 43/48] ivshmem: use qemu_strtosz() marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 44/48] ivshmem: add hostmem backend marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 45/48] ivshmem: remove EventfdEntry.vector marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 46/48] ivshmem: rename MSI eventfd_table marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 47/48] ivshmem: use kvm irqfd for msi notifications marcandre.lureau
2015-10-06 19:19 ` [Qemu-devel] [PULL 48/48] ivshmem: use little-endian int64_t for the protocol marcandre.lureau
2015-10-07 12:11 ` [Qemu-devel] [PULL 00/48] ivshmem series Andreas Färber
2015-10-07 12:16   ` Marc-André Lureau [this message]
2015-10-07 12:31     ` Andreas Färber
2015-10-07 12:44       ` Marc-André Lureau
2015-10-10 22:18         ` [Qemu-devel] [PATCH 1/2] tests: Add ivshmem qtest Andreas Färber
2015-10-10 22:18           ` [Qemu-devel] [PATCH 2/2] ivshmem-test: Implement tests Andreas Färber
2015-10-10 22:28             ` Andreas Färber
2015-10-10 23:10           ` [Qemu-devel] [PATCH 1/2] tests: Add ivshmem qtest Marc-André Lureau
2015-10-07 22:24       ` [Qemu-devel] [PULL 00/48] ivshmem series Paolo Bonzini
2015-10-07 12:42     ` Andrew Jones
2015-10-07 13:05       ` Andreas Färber
2015-10-07 13:26         ` Marc-André Lureau
2015-10-07 22:00         ` Peter Maydell
2015-10-09 11:55 ` Pavel Fedin
2015-10-09 12:12   ` Marc-André Lureau
2015-10-09 12:29     ` Pavel Fedin
2015-10-09 12:45       ` Marc-André Lureau
2015-10-09 12:47         ` Paolo Bonzini
2015-10-09 13:02           ` Pavel Fedin
2015-10-09 13:07             ` Paolo Bonzini
2015-10-09 12:51         ` Pavel Fedin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2075219250.26126659.1444220200013.JavaMail.zimbra@redhat.com \
    --to=mlureau@redhat.com \
    --cc=afaerber@suse.de \
    --cc=marcandre.lureau@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).