qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
	qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, hreitz@redhat.com, kwolf@redhat.com,
	jsnow@redhat.com, f.ebner@proxmox.com
Subject: Re: [PATCH] iotests/pylintrc: allow up to 10 similar lines
Date: Tue, 30 Apr 2024 11:17:07 +0200	[thread overview]
Message-ID: <207d246d-28bc-4998-9177-7fbd7c1cc9df@linaro.org> (raw)
In-Reply-To: <20240430091329.2365053-1-vsementsov@yandex-team.ru>

On 30/4/24 11:13, Vladimir Sementsov-Ogievskiy wrote:
> We want to have similar QMP objects in different tests. Reworking these
> objects to make common parts by calling some helper functions doesn't
> seem good. It's a lot more comfortable to see the whole QAPI request in
> one place.
> 
> So, let's increase the limit, to unblock further commit
> "iotests: add backup-discard-source"
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
> 
> Hi all! That's a patch to unblock my PR
> "[PULL 0/6] Block jobs patches for 2024-04-29"
>    <20240429115157.2260885-1-vsementsov@yandex-team.ru>
>    https://patchew.org/QEMU/20240429115157.2260885-1-vsementsov@yandex-team.ru/
> 
> 
>   tests/qemu-iotests/pylintrc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/pylintrc b/tests/qemu-iotests/pylintrc
> index de2e0c2781..05b75ee59b 100644
> --- a/tests/qemu-iotests/pylintrc
> +++ b/tests/qemu-iotests/pylintrc
> @@ -55,4 +55,4 @@ max-line-length=79
>   
>   [SIMILARITIES]
>   
> -min-similarity-lines=6
> +min-similarity-lines=10

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



  reply	other threads:[~2024-04-30  9:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30  9:13 [PATCH] iotests/pylintrc: allow up to 10 similar lines Vladimir Sementsov-Ogievskiy
2024-04-30  9:17 ` Philippe Mathieu-Daudé [this message]
2024-05-28 12:49 ` Vladimir Sementsov-Ogievskiy
2024-05-28 15:17   ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=207d246d-28bc-4998-9177-7fbd7c1cc9df@linaro.org \
    --to=philmd@linaro.org \
    --cc=f.ebner@proxmox.com \
    --cc=hreitz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).