From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70D18CA9EAF for ; Mon, 21 Oct 2019 10:25:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 458B72084C for ; Mon, 21 Oct 2019 10:25:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 458B72084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMUs7-0002QO-7i for qemu-devel@archiver.kernel.org; Mon, 21 Oct 2019 06:25:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42230) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMUrM-0001oy-PP for qemu-devel@nongnu.org; Mon, 21 Oct 2019 06:24:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMUrK-00087V-Bz for qemu-devel@nongnu.org; Mon, 21 Oct 2019 06:24:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60170) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iMUrK-000879-3K for qemu-devel@nongnu.org; Mon, 21 Oct 2019 06:24:18 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 850328665D for ; Mon, 21 Oct 2019 10:24:16 +0000 (UTC) Received: by mail-wr1-f70.google.com with SMTP id 92so1671173wro.14 for ; Mon, 21 Oct 2019 03:24:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Y6lgkEMeo/P5YqhO22xBujs9RBLH4RZsExzcJGqQ9hg=; b=AgrmLG4lSlnLvpVq1A9mrdEJb4bpyv6zIRFUliYIilr2WFLvLcSqcXaW0avQ0VwcOC xJc+tSR30RYakzDBp9/GTwlPLay+fn/pie7GAtgtXhfk6edWyKzrG/i4lGHIkZr0gAT8 zn3KMqAHKc4qmtl4rZ/Zi4T1QPosDWHO+2x+LhxbNv7GOc60VBD8C1TU5UraNrfMwp7G IEi5sW0sXOABAQ+GjJGol21xhAQ03GKniLNbpkAUVyBm4VEKqGDWlYfqzNH0Gxx++Aks EHqtYTjTOwzv2qQ2rbylIWbHmuwbiQE3HXwkw1ZY50h+mA8/B2SqfVbTU/yZbW1bmQtH digg== X-Gm-Message-State: APjAAAXHHJeFWnGzcWpyTJharrs9hkjyyu1nn4gkzrtFR/x9p1iKCgeZ lZmb+RY8d9SYXAyXEhXoqLB1q4bIWP5Y7k8gXsxHnSJVTKy928uQv00Vyr4pDVn6IBgTcKvspvF Mqov2Wtfir1bdXFA= X-Received: by 2002:adf:b1d1:: with SMTP id r17mr4572330wra.201.1571653455242; Mon, 21 Oct 2019 03:24:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqwJTPwc4mpVM+xxgKThg7eNCojrx8MRcIVimkqN/hF39WrM8mYrjjIIRc9pP4pm4WYLBK4GyA== X-Received: by 2002:adf:b1d1:: with SMTP id r17mr4572271wra.201.1571653454929; Mon, 21 Oct 2019 03:24:14 -0700 (PDT) Received: from [192.168.1.41] (129.red-83-57-174.dynamicip.rima-tde.net. [83.57.174.129]) by smtp.gmail.com with ESMTPSA id n205sm1642696wmf.22.2019.10.21.03.24.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Oct 2019 03:24:14 -0700 (PDT) Subject: Re: [PATCH 12/21] hw/arm: Let the machine be the owner of the system memory To: Peter Maydell , Paolo Bonzini , "Dr. David Alan Gilbert" References: <20191020225650.3671-1-philmd@redhat.com> <20191020225650.3671-13-philmd@redhat.com> <42944bea-4b15-7bdf-61a7-f1c73f5f7c2b@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <20804096-7b34-9d79-1d93-fa9a31bbfd66@redhat.com> Date: Mon, 21 Oct 2019 12:24:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Burton , "Michael S. Tsirkin" , Leif Lindholm , Mark Cave-Ayland , QEMU Developers , KONRAD Frederic , "Edgar E. Iglesias" , Rob Herring , Andrey Smirnov , Helge Deller , Markus Armbruster , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Joel Stanley , Aleksandar Rikalo , Richard Henderson , Artyom Tarasenko , Antony Pavlov , Eduardo Habkost , Alistair Francis , Fabien Chouteau , Beniamino Galvani , qemu-arm , Jan Kiszka , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Igor Mammedov , David Gibson , patchew-devel@redhat.com, Radoslaw Biernacki , Thomas Huth , Andrew Baumann , Jean-Christophe Dubois , Andrew Jeffery , Michael Walle , qemu-ppc , Aleksandar Markovic , Peter Chubb , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Cc'ing Paolo/David. On 10/21/19 11:39 AM, Peter Maydell wrote: > On Mon, 21 Oct 2019 at 10:34, Philippe Mathieu-Daud=C3=A9 wrote: >> >> On 10/21/19 11:22 AM, Peter Maydell wrote: >>> On Mon, 21 Oct 2019 at 00:01, Philippe Mathieu-Daud=C3=A9 wrote: >>>> >>>> Signed-off-by: Philippe Mathieu-Daud=C3=A9 >>>> --- >>> >>>> hw/arm/virt.c | 2 +- >>> >>> I think from a quick code scan that this is ok, but did >>> you test that migration compat from old to new still works? >>> I vaguely recall that there are some cases when adding an >>> owner to a memory region changes the name string used for >>> identifying the ramblock in migration. >> >> It seems to still works: >> >> $ make check-qtest-aarch64 V=3D1 >=20 >> This test migrate the virt machine. >> >> Is this enough? >=20 > No, you need to test migration from a QEMU binary without > this patchset to a QEMU binary that has it. Otherwise you're > only checking that the new version can migrate from itself > to itself. I find the easiest way to test this is just to > use the 'savevm' command to save a state snapshot to a > qcow2 disk image while running the old binary, and then run > 'loadvm' with the new binary and check it restored OK. I did not think if this case. I followed your blog post [*] and tested the migration works OK. Paolo, now thinking about regular testing, we should add this testing to=20 patchew too. Something like: - when mainstream/master is updated, patchew build QEMU (it should be=20 already mostly ccached) and generate some vm dumps with 'savevm'. - build/test the series - if series succeeded testing, run 'loadvm' tests [*]=20 https://translatedcode.wordpress.com/2015/07/06/tricks-for-debugging-qemu= -savevm-snapshots/