From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53401)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1a3kz7-0008GQ-QH
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:28:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1a3kz2-0003YW-QR
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:28:45 -0500
Received: from mx4-phx2.redhat.com ([209.132.183.25]:39984)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1a3kz2-0003Y7-Ju
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:28:40 -0500
Date: Tue, 1 Dec 2015 08:28:38 -0500 (EST)
From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <mlureau@redhat.com>
Message-ID: <2082157739.21425851.1448976518326.JavaMail.zimbra@redhat.com>
In-Reply-To: <877fkyb9ha.fsf@linaro.org>
References: <1448901890-17012-1-git-send-email-marcandre.lureau@redhat.com>
	<1448901890-17012-5-git-send-email-marcandre.lureau@redhat.com>
	<877fkyb9ha.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-2.5 v4 4/4] tests: add vhost-user-test
 when target is x64 only
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
Cc: marcandre lureau <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org, mst@redhat.com

Hi

----- Original Message -----
> > diff --git a/tests/Makefile b/tests/Makefile
> > index 0ef00a1..cf1228b 100644
> > --- a/tests/Makefile
> > +++ b/tests/Makefile
> > @@ -198,13 +198,13 @@ check-qtest-i386-y += tests/pc-cpu-test$(EXESUF)
> >  check-qtest-i386-y += tests/q35-test$(EXESUF)
> >  gcov-files-i386-y += hw/pci-host/q35.c
> >  check-qtest-i386-$(CONFIG_VHOST_NET_TEST_i386) +=
> >  tests/vhost-user-test$(EXESUF)
> > -ifeq ($(CONFIG_VHOST_NET_TEST_i386),)
> > -check-qtest-x86_64-$(CONFIG_VHOST_NET_TEST_x86_64) +=
> > tests/vhost-user-test$(EXESUF)
> > -endif
> >  check-qtest-i386-y += tests/test-netfilter$(EXESUF)
> >  check-qtest-x86_64-y = $(check-qtest-i386-y)
> >  gcov-files-i386-y += i386-softmmu/hw/timer/mc146818rtc.c
> >  gcov-files-x86_64-y = $(subst
> >  i386-softmmu/,x86_64-softmmu/,$(gcov-files-i386-y))
> > +ifeq ($(CONFIG_VHOST_NET_TEST_i386),)
> > +check-qtest-x86_64-$(CONFIG_VHOST_NET_TEST_x86_64) +=
> > tests/vhost-user-test$(EXESUF)
> > +endif
> 
> So is this limitation due to the guest binary we need to test this?
> Surely any KVM enabled build with vhost support should be able to run
> the test?

Any that has CONFIG_VHOST_NET_TEST_$target_name set in configure. It looks like we are
missing other than x86 hosts support in the Makefile, but I don't have other than
x86 kvm-enabled hosts to test it. I suppose this is better to be addresses after 2.5.