From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBQHJ-0002uB-EO for qemu-devel@nongnu.org; Tue, 11 Sep 2012 09:13:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBQHB-000251-Tn for qemu-devel@nongnu.org; Tue, 11 Sep 2012 09:13:21 -0400 Received: from mx3-phx2.redhat.com ([209.132.183.24]:57425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBQHB-00024x-L5 for qemu-devel@nongnu.org; Tue, 11 Sep 2012 09:13:13 -0400 Date: Tue, 11 Sep 2012 09:12:36 -0400 (EDT) From: Paolo Bonzini Message-ID: <208319241.67713539.1347369156438.JavaMail.root@redhat.com> In-Reply-To: <504F3779.2090407@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 19/47] block: add bdrv_query_info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: jcody@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com ----- Messaggio originale ----- > Da: "Kevin Wolf" > A: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, eblake@redhat.com, jcody@redhat.com, stefanha@= linux.vnet.ibm.com > Inviato: Marted=C3=AC, 11 settembre 2012 15:07:05 > Oggetto: Re: [PATCH 19/47] block: add bdrv_query_info >=20 > Am 24.07.2012 13:03, schrieb Paolo Bonzini: > > Extract it out of the implementation of "info block". > >=20 > > Signed-off-by: Paolo Bonzini > > --- > > block.c | 104 > > +++++++++++++++++++++++++++++++-------------------------------- > > block.h | 1 + > > 2 files changed, 53 insertions(+), 52 deletions(-) >=20 > The refactoring looks correct, but why do you put the function between > qmp_query_blockstat and qmp_query_blockstats? If you put it next to > qmp_query_block, both functions pairs stay closer together. Ok, will do. Paolo