From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54391) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwcEX-0000mx-Uu for qemu-devel@nongnu.org; Tue, 18 Oct 2016 17:47:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwcEU-0000jc-P5 for qemu-devel@nongnu.org; Tue, 18 Oct 2016 17:47:42 -0400 Received: from mx6-phx2.redhat.com ([209.132.183.39]:50752) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwcEU-0000iR-GA for qemu-devel@nongnu.org; Tue, 18 Oct 2016 17:47:38 -0400 Date: Tue, 18 Oct 2016 17:47:35 -0400 (EDT) From: Paolo Bonzini Message-ID: <2085206461.5117291.1476827255571.JavaMail.zimbra@redhat.com> In-Reply-To: <20161018192445.413c040d.cornelia.huck@de.ibm.com> References: <1476100421-28772-1-git-send-email-pbonzini@redhat.com> <20161018192445.413c040d.cornelia.huck@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/12] virtio: cleanup ioeventfd start/stop List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: qemu-devel@nongnu.org, stefanha@redhat.com, borntraeger@de.ibm.com, famz@redhat.com, mst@redhat.com ----- Original Message ----- > From: "Cornelia Huck" > To: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, stefanha@redhat.com, borntraeger@de.ibm.com, famz@redhat.com, mst@redhat.com > Sent: Tuesday, October 18, 2016 7:24:45 PM > Subject: Re: [PATCH 00/12] virtio: cleanup ioeventfd start/stop > > On Mon, 10 Oct 2016 13:53:28 +0200 > Paolo Bonzini wrote: > > > This series started as an attempt to always use the dataplane path > > for virtio-blk and virtio-scsi when ioeventfd is active. The aim > > was three-fold: > > > > 1) to add more coverage for dataplane > > > > 2) to remove virtio_add_queue_aio > > > > 3) to simplify the dataplane start/stop code > > > > It achieves the first two objectives, and while it doesn't quite > > achieve the third it does cleanup the generic ioeventfd code in > > virtio-bus more than I expected. In particular, it reduces the set > > of callbacks that transports must implement, and it removes the ugly > > case where ioeventfd is started with generic callbacks and then moved > > to the dataplane callbacks. It also enables some simplification of the > > functions that deal with host notifiers, and detects some configuration > > errors better. > > > > I've tested it with virtio-blk, virtio-scsi and vhost-net. > > Do you have a branch somewhere? ioeventfd-virtio at git://github.com/bonzini/qemu.git Paolo > > > > Patch 1 is a bugfix that I found while testing the TCG+dataplane combo. > > > > Patches 2 and 3 are simplifications that are too nice to leave > > them for later in the series. > > > > Patch 4 moves some of the ioeventfd code from virtio-bus.c to > > virtio.c. At this point the transition is a bit half-assed, but > > this changes as soon as we remove the generic->dataplane > > handler transition. > > > > Patches 5 to 7 do exactly that, and then the spring cleaning > > begins, lasting for the whole second half of the series. > > I'll continue to look at the patches from 4 on tomorrow. > >