From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bw7q8-0001RZ-4w for qemu-devel@nongnu.org; Mon, 17 Oct 2016 09:20:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bw7q3-0001Q5-LR for qemu-devel@nongnu.org; Mon, 17 Oct 2016 09:20:28 -0400 Received: from mx5-phx2.redhat.com ([209.132.183.37]:59397) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bw7q3-0001Pj-Dt for qemu-devel@nongnu.org; Mon, 17 Oct 2016 09:20:23 -0400 Date: Mon, 17 Oct 2016 09:20:14 -0400 (EDT) From: Paolo Bonzini Message-ID: <2092464752.4037718.1476710414759.JavaMail.zimbra@redhat.com> In-Reply-To: <34EFBCA9F01B0748BEB6B629CE643AE60B058146@szxeml561-mbx.china.huawei.com> References: <34EFBCA9F01B0748BEB6B629CE643AE60B058146@szxeml561-mbx.china.huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] A question about this commit "char: convert from GIOChannel to QIOChannel" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: wangyunjian Cc: berrange@redhat.com, qemu-devel@nongnu.org, caihe ----- Original Message ----- > From: "wangyunjian" > To: berrange@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org > Cc: "caihe" > Sent: Monday, October 17, 2016 3:02:32 PM > Subject: A question about this commit "char: convert from GIOChannel to Q= IOChannel" >=20 > Commit 9894dc0cdcc397ee5b26370bc53da6d360a363c2 =E2=80=9Cchar: convert fr= om > GIOChannel to QIOChannel=E2=80=9D, > the old version will call closesocket when tcp_chr_close and udp_chr_clos= e > are called. But the new version will not call closesocket. >=20 > This can bring to a socket leak? Hi, closesocket is called in io/channel-socket.c (qio_channel_socket_finali= ze). Thanks, Paolo