qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1.3?] multiboot: fix e801 memory map
Date: Thu, 29 Nov 2012 14:21:50 -0500 (EST)	[thread overview]
Message-ID: <2093724096.16404973.1354216910353.JavaMail.root@redhat.com> (raw)
In-Reply-To: <E7818045-EC82-43CC-9BE3-82BEA3586DC0@suse.de>



----- Messaggio originale -----
> Da: "Alexander Graf" <agraf@suse.de>
> A: "Paolo Bonzini" <pbonzini@redhat.com>
> Cc: qemu-devel@nongnu.org
> Inviato: Giovedì, 29 novembre 2012 19:51:07
> Oggetto: Re: [PATCH 1.3?] multiboot: fix e801 memory map
> 
> 
> On 29.11.2012, at 18:11, Paolo Bonzini wrote:
> 
> > The e801 memory sizes in the multiboot structures hard-code the available
> > low memory to 640.  However, the value should not include the size
> > of the EBDA.  Fill the value in the option ROM, getting the size of low
> > memory from the BIOS.
> 
> The description mentions that instead of hard coding, you fetch the
> value dynamically via a BIOS call. However, I don't see the code
> that hard codes it changed. Where is that one?

It is in hw/multiboot.c:

    stl_p(bootinfo + MBI_MEM_LOWER,   640);


Regarding the testcase, Xen will touch the EBDA without this patch and
with http://permalink.gmane.org/gmane.comp.emulators.xen.devel/144855.
However, SeaBIOS does not complain.

Paolo

  reply	other threads:[~2012-11-29 19:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-29 17:11 [Qemu-devel] [PATCH 1.3?] multiboot: fix e801 memory map Paolo Bonzini
2012-11-29 17:11 ` [Qemu-devel] [PATCH] " Paolo Bonzini
2012-11-29 18:49 ` [Qemu-devel] [PATCH 1.3?] " Alexander Graf
2012-11-29 18:51 ` Alexander Graf
2012-11-29 19:21   ` Paolo Bonzini [this message]
2012-11-29 19:24     ` Alexander Graf
2012-11-29 19:40       ` Paolo Bonzini
2012-11-29 21:12         ` Anthony Liguori
2012-11-30 16:15 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2093724096.16404973.1354216910353.JavaMail.root@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).