From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Te9gK-0008L4-0t for qemu-devel@nongnu.org; Thu, 29 Nov 2012 14:22:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Te9gF-0004om-PF for qemu-devel@nongnu.org; Thu, 29 Nov 2012 14:21:55 -0500 Received: from mx4-phx2.redhat.com ([209.132.183.25]:41492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Te9gF-0004og-GB for qemu-devel@nongnu.org; Thu, 29 Nov 2012 14:21:51 -0500 Date: Thu, 29 Nov 2012 14:21:50 -0500 (EST) From: Paolo Bonzini Message-ID: <2093724096.16404973.1354216910353.JavaMail.root@redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1.3?] multiboot: fix e801 memory map List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org ----- Messaggio originale ----- > Da: "Alexander Graf" > A: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org > Inviato: Gioved=C3=AC, 29 novembre 2012 19:51:07 > Oggetto: Re: [PATCH 1.3?] multiboot: fix e801 memory map >=20 >=20 > On 29.11.2012, at 18:11, Paolo Bonzini wrote: >=20 > > The e801 memory sizes in the multiboot structures hard-code the availab= le > > low memory to 640. However, the value should not include the size > > of the EBDA. Fill the value in the option ROM, getting the size of low > > memory from the BIOS. >=20 > The description mentions that instead of hard coding, you fetch the > value dynamically via a BIOS call. However, I don't see the code > that hard codes it changed. Where is that one? It is in hw/multiboot.c: stl_p(bootinfo + MBI_MEM_LOWER, 640); Regarding the testcase, Xen will touch the EBDA without this patch and with http://permalink.gmane.org/gmane.comp.emulators.xen.devel/144855. However, SeaBIOS does not complain. Paolo