From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] hw/timer/mc146818rtc: Only include qapi-commands-misc on I386
Date: Tue, 22 Oct 2019 18:48:39 +0200 [thread overview]
Message-ID: <20ba703a-b25f-078b-69fa-dcc5a7072ccf@redhat.com> (raw)
In-Reply-To: <20191017162614.21327-1-philmd@redhat.com>
On 17/10/19 18:26, Philippe Mathieu-Daudé wrote:
> Commit a6c7040fb09 restricted the rtc-reset-reinjection command
> to the I386 target.
> Restrict the "qapi/qapi-commands-misc-target.h" header to it too.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/timer/mc146818rtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
> index 6cb378751b..c1eb0a7376 100644
> --- a/hw/timer/mc146818rtc.c
> +++ b/hw/timer/mc146818rtc.c
> @@ -37,12 +37,12 @@
> #include "hw/timer/mc146818rtc.h"
> #include "migration/vmstate.h"
> #include "qapi/error.h"
> -#include "qapi/qapi-commands-misc-target.h"
> #include "qapi/qapi-events-misc-target.h"
> #include "qapi/visitor.h"
> #include "exec/address-spaces.h"
>
> #ifdef TARGET_I386
> +#include "qapi/qapi-commands-misc-target.h"
> #include "hw/i386/apic.h"
> #endif
>
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2019-10-22 17:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 16:26 [PATCH] hw/timer/mc146818rtc: Only include qapi-commands-misc on I386 Philippe Mathieu-Daudé
2019-10-22 16:48 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20ba703a-b25f-078b-69fa-dcc5a7072ccf@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).