From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Greg Kurz <groug@kaod.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Anthony Perard <anthony.perard@citrix.com>,
Paul Durrant <paul@xen.org>
Subject: Re: [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size
Date: Sun, 10 May 2020 20:43:41 +0200 [thread overview]
Message-ID: <2111838.FFCTJPLGb3@silver> (raw)
In-Reply-To: <54f3b9c9f05a77ccdd6103bd46c828fcb675cbac.1589132512.git.qemu_oss@crudebyte.com>
On Sonntag, 10. Mai 2020 19:18:21 CEST Christian Schoenebeck wrote:
> Commit SHA-1 16724a173049ac29c7b5ade741da93a0f46edff7 introduced
> truncating the response to the currently available transport buffer
> size, which was supposed to fix an 9pfs error on Xen boot where
> transport buffer might still be smaller than required for response.
>
> Unfortunately this change broke small reads (with less than 12
> bytes).
>
> To address both concerns, check the actual response type and only
> truncate reply for Rreaddir responses, and only if truncated reply
> would at least return one payload byte to client. Use Rreaddir's
> precise header size (11) for this instead of P9_IOHDRSZ.
Oops, that should have been "Rread's" of course, not "Rreaddir's". Apparently
I already spent too much time on readdir() code.
If there's not more to do, then maybe you could just amend this log message
typo Greg? I would appreciate it.
Best regards,
Christian Schoenebeck
next prev parent reply other threads:[~2020-05-10 18:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 17:41 [PATCH 0/2] 9pfs: regression init_in_iov_from_pdu truncating size Christian Schoenebeck
2020-05-10 17:05 ` [PATCH 1/2] xen-9pfs: Fix log messages of reply errors Christian Schoenebeck
2020-05-11 22:09 ` Stefano Stabellini
2020-05-10 17:18 ` [PATCH 2/2] 9pfs: fix init_in_iov_from_pdu truncating size Christian Schoenebeck
2020-05-10 18:43 ` Christian Schoenebeck [this message]
2020-05-11 22:09 ` Stefano Stabellini
2020-05-12 11:29 ` Christian Schoenebeck
2020-05-12 23:24 ` Stefano Stabellini
2020-05-13 13:11 ` Christian Schoenebeck
2020-05-13 23:31 ` Stefano Stabellini
2020-05-14 14:24 ` Christian Schoenebeck
2020-05-14 15:51 ` Stefano Stabellini
2020-05-14 16:10 ` Christian Schoenebeck
2020-05-14 16:23 ` Stefano Stabellini
2020-05-14 16:24 ` Stefano Stabellini
2020-05-14 17:21 ` Christian Schoenebeck
2020-05-12 9:38 ` [PATCH 0/2] 9pfs: regression " Greg Kurz
2020-05-13 23:07 ` Greg Kurz
2020-05-13 23:33 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2111838.FFCTJPLGb3@silver \
--to=qemu_oss@crudebyte.com \
--cc=anthony.perard@citrix.com \
--cc=groug@kaod.org \
--cc=paul@xen.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).