From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EC6CC2D0A3 for ; Sun, 1 Nov 2020 10:18:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DEAB620719 for ; Sun, 1 Nov 2020 10:18:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=crudebyte.com header.i=@crudebyte.com header.b="JgKPfMxN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEAB620719 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=crudebyte.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZARt-00051I-Sj for qemu-devel@archiver.kernel.org; Sun, 01 Nov 2020 05:18:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZAQx-0004Zf-Nv for qemu-devel@nongnu.org; Sun, 01 Nov 2020 05:17:59 -0500 Received: from lizzy.crudebyte.com ([91.194.90.13]:43159) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZAQv-000233-Ox for qemu-devel@nongnu.org; Sun, 01 Nov 2020 05:17:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=lizzy; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Content-ID:Content-Description; bh=kAXSE9BqXgvb1/7cyHBKAfP37qlzF5HfcV5J8MPUhJU=; b=JgKPfMxNbrFoXz75ljoiNfGyla i+cjELgmyDr3qcb1LqRCg5bvp0Jzy+78jeZqG48FyMv5vr+8X5wDVb/wa8umTUkMP7u5feolC0f0O KPjoWceLKGwV0Zj5O8AbKNVJLrnZw15f2jTfusoXHL7X2b72bZRJ4XSa9l54kHW2oymrhNuxYnrjT Kt2Y62KzCoLezG7/cf30eoc4goM6JgK2eTHIHS3L9LqTuZi4E0WPjcDM/nN6GGd2gy4Du7tyQrHn2 a4Mh0xmlIHgEMrAZAt1qYGSje98uxXAAsnyWTgimG2qw7gBmSwcXHOGddrAyfO0AlodtDecf3Bd8O OgEP5Leg==; From: Christian Schoenebeck To: qemu-devel@nongnu.org Cc: Peter Xu , Peter Maydell , Bihong Yu , Juan Quintela , "Dr. David Alan Gilbert (git)" Subject: Re: [PULL 00/16] migration queue Date: Sun, 01 Nov 2020 11:17:50 +0100 Message-ID: <2112217.elGldtz0XA@silver> In-Reply-To: <1908851.GJEdv41Ba9@silver> References: <20201026161952.149188-1-dgilbert@redhat.com> <20201031174611.GG6357@xz-x1> <1908851.GJEdv41Ba9@silver> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: pass client-ip=91.194.90.13; envelope-from=qemu_oss@crudebyte.com; helo=lizzy.crudebyte.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/01 05:17:55 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Samstag, 31. Oktober 2020 20:10:49 CET Christian Schoenebeck wrote: > On Samstag, 31. Oktober 2020 18:46:11 CET Peter Xu wrote: > > On Sat, Oct 31, 2020 at 05:26:28PM +0000, Peter Maydell wrote: > > > On Sat, 31 Oct 2020 at 16:12, Christian Schoenebeck > > > > > > wrote: > > > > On Montag, 26. Oktober 2020 17:19:36 CET Dr. David Alan Gilbert (git) > > wrote: > > > > > ---------------------------------------------------------------- > > > > > migration pull: 2020-10-26 > > > > > > > > > > Another go at Peter's postcopy fixes > > > > > > > > > > Cleanups from Bihong Yu and Peter Maydell. > > > > > > > > > > Signed-off-by: Dr. David Alan Gilbert > > > > > > > > May it be possible that this PR introduced a lockup of the qtests that > > > > I > > > > am > > > > encountering in this week's upstream revisions? > > > > > > If you try the patches Peter Xu attached to this thread > > > does the lockup go away ? > > > > > > https://lore.kernel.org/qemu-devel/20201030135350.GA588069@xz-x1/ > > > > > > (I'm also seeing intermittent hangs, for some reason almost always > > > on s390x host.) > > > > It would be good to know exactly which test hanged. If it's > > migration-test > > then it's very possible. > > It's run-test-144 that does not return; according to Makefile.mtest that's > migration-test, so chances are high that it's indeed introduced by this PR. > > > The race above patch(es) tried to fix should logically be reproducable on > > all archs, not s390x only. > > > > Thanks, > > Yes, it's i386 here that locks up. > > I'm running the loop with your patches now, so far so good, let's see if > it's still alive tomorrow. > > Best regards, > Christian Schoenebeck Looks good! 16h later and the loop is still running here; it also made the lockup to disappear on Travis-CI. So Peter Xu's two patches fix the lockup problem for me. Best regards, Christian Schoenebeck