From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 4/4] crypto: report which ciphers are being skipped during tests
Date: Mon, 11 Mar 2024 17:20:21 +0100 [thread overview]
Message-ID: <211263fc-db3d-4fa9-aefa-17df0a8f63f1@redhat.com> (raw)
In-Reply-To: <20240311121929.212472-5-berrange@redhat.com>
On 11/03/2024 13.19, Daniel P. Berrangé wrote:
> Since the ciphers can be dynamically disabled at runtime, when running
> unit tests it is helpful to report which ciphers we can skipped for
> testing.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> tests/unit/test-crypto-cipher.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/unit/test-crypto-cipher.c b/tests/unit/test-crypto-cipher.c
> index d0ea7b4d8e..f5152e569d 100644
> --- a/tests/unit/test-crypto-cipher.c
> +++ b/tests/unit/test-crypto-cipher.c
> @@ -821,6 +821,10 @@ int main(int argc, char **argv)
> for (i = 0; i < G_N_ELEMENTS(test_data); i++) {
> if (qcrypto_cipher_supports(test_data[i].alg, test_data[i].mode)) {
> g_test_add_data_func(test_data[i].path, &test_data[i], test_cipher);
> + } else {
> + g_printerr("# skip unsupported %s:%s\n",
> + QCryptoCipherAlgorithm_str(test_data[i].alg),
> + QCryptoCipherMode_str(test_data[i].mode));
> }
> }
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2024-03-11 16:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 12:19 [PATCH 0/4] crypto: handle gcrypt ciphers being disabled Daniel P. Berrangé
2024-03-11 12:19 ` [PATCH 1/4] crypto: factor out conversion of QAPI to gcrypt constants Daniel P. Berrangé
2024-03-11 16:04 ` Thomas Huth
2024-03-11 12:19 ` [PATCH 2/4] crypto: query gcrypt for cipher availability Daniel P. Berrangé
2024-03-11 16:16 ` Thomas Huth
2024-03-11 12:19 ` [PATCH 3/4] crypto: use error_abort for unexpected failures Daniel P. Berrangé
2024-03-11 16:19 ` Thomas Huth
2024-03-11 12:19 ` [PATCH 4/4] crypto: report which ciphers are being skipped during tests Daniel P. Berrangé
2024-03-11 16:20 ` Thomas Huth [this message]
2024-03-11 14:15 ` [PATCH 0/4] crypto: handle gcrypt ciphers being disabled Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=211263fc-db3d-4fa9-aefa-17df0a8f63f1@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).