From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VDrj7-00022k-5X for qemu-devel@nongnu.org; Mon, 26 Aug 2013 04:00:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VDrj0-0005Qt-Od for qemu-devel@nongnu.org; Mon, 26 Aug 2013 04:00:41 -0400 Received: from mx3-phx2.redhat.com ([209.132.183.24]:45186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VDrj0-0005QT-13 for qemu-devel@nongnu.org; Mon, 26 Aug 2013 04:00:34 -0400 Date: Mon, 26 Aug 2013 04:00:07 -0400 (EDT) From: Andrew Jones Message-ID: <2119643893.455450.1377504007366.JavaMail.root@redhat.com> In-Reply-To: <521B0727.30602@redhat.com> References: <1377185968-13129-1-git-send-email-drjones@redhat.com> <52163A7F.7020402@suse.de> <795650865.3095841.1377257598867.JavaMail.root@redhat.com> <521B0727.30602@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] kvm: warn if num cpus is greater than num recommended List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kvm@vger.kernel.org, gleb@redhat.com, libvir-list@redhat.com, mtosatti@redhat.com, qemu-devel developers , Andreas =?utf-8?Q?F=C3=A4rber?= , Eduardo Habkost ----- Original Message ----- > Il 23/08/2013 13:33, Andrew Jones ha scritto: > > Does smp_cpus map to the current > > number of cpus, or to the number of possible cpus? If it maps to the number > > of possible cpus, then this is the right place. If the former, then I guess > > it'll take more thought. I'ved added Igor (still on vacation) to this > > reply, > > but regardless I vote we worry about hot-plug limit checking in different > > patch. > > smp_cpus is the initial number, max_cpus is the number of possible cpus. > Yeah, I noticed that this issue is at least partially addressed already with my v2, which incorporates Marcelo's check against the number of hotpluggable cpus (max_cpus). drew