From: Richard Henderson <richard.henderson@linaro.org>
To: quintela@redhat.com
Cc: qemu-devel@nongnu.org, Andrei Gudkov <gudkov.andrei@huawei.com>,
Leonardo Bras <leobras@redhat.com>,
Chuan Zheng <zhengchuan@huawei.com>, Peter Xu <peterx@redhat.com>,
Zhenzhong Duan <zhenzhong.duan@intel.com>
Subject: Re: [PATCH 3/3] migration: Make dirtyrate.c target independent
Date: Thu, 11 May 2023 12:52:31 +0100 [thread overview]
Message-ID: <21302f37-fc1f-a39c-639d-d9a9ccd3ca9f@linaro.org> (raw)
In-Reply-To: <87ttwj3xbl.fsf@secure.mitica>
On 5/11/23 12:46, Juan Quintela wrote:
>>> +softmmu_ss.add(when: 'CONFIG_SOFTMMU', if_true: files('dirtyrate.c'))
>>
>> This becomes
>>
>> softmmu_ss.add(files('dirtyrate.c'))
>>
>> the when: is redundant with 'softmmu_ss'.
>
> It looked weird, but I didn't understand this stuff well enough, so I
> just copyed what was there O:-)
>
> Is there any documentation about this? Because what I usually do is
> search for a file that does (more or less) the same that I need and just
> add it to that list.
It's just top-level make^H^H^H^Hmeson.build related.
We have
common_ss.add_all(when: 'CONFIG_SOFTMMU', if_true: [softmmu_ss])
so everything in softmmu_ss is already protected by CONFIG_SOFTMMU.
r~
prev parent reply other threads:[~2023-05-11 11:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 9:22 [PATCH 0/3] migration: Make dirtyrate.c target independent Juan Quintela
2023-05-11 9:22 ` [PATCH 1/3] migration: Teach dirtyrate about qemu_target_page_size() Juan Quintela
2023-05-11 11:07 ` Richard Henderson
2023-05-11 11:44 ` Juan Quintela
2023-05-11 13:12 ` Juan Quintela
2023-05-11 14:36 ` gudkov.andrei--- via
2023-05-11 9:22 ` [PATCH 2/3] migration: Teach dirtyrate about qemu_target_page_bits() Juan Quintela
2023-05-11 11:08 ` Richard Henderson
2023-05-11 12:01 ` Philippe Mathieu-Daudé
2023-05-11 9:22 ` [PATCH 3/3] migration: Make dirtyrate.c target independent Juan Quintela
2023-05-11 11:09 ` Richard Henderson
2023-05-11 11:46 ` Juan Quintela
2023-05-11 11:52 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21302f37-fc1f-a39c-639d-d9a9ccd3ca9f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=gudkov.andrei@huawei.com \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhengchuan@huawei.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).