qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Sergei Trofimovich <slyfox@gentoo.org>, qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH] pc-bios/descriptors: fix paths in json files
Date: Mon, 1 Feb 2021 09:31:55 +0100	[thread overview]
Message-ID: <2133b6f7-9128-a98c-66c8-72ef223d23f6@redhat.com> (raw)
In-Reply-To: <20210131143434.2513363-1-slyfox@gentoo.org>

On 31/01/21 15:34, Sergei Trofimovich wrote:
> Before the change /usr/share/qemu/firmware/50-edk2-x86_64-secure.json
> contained the relative path:
>              "filename": "share/qemu/edk2-x86_64-secure-code.fd",
>              "filename": "share/qemu/edk2-i386-vars.fd",
> 
> After then change the paths are absolute:
>              "filename": "/usr/share/qemu/edk2-x86_64-secure-code.fd",
>              "filename": "/usr/share/qemu/edk2-i386-vars.fd",
> 
> The regression appeared in qemu-5.2.0 (seems to be related
> to meson port).
> 
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: "Marc-André Lureau" <marcandre.lureau@redhat.com>
> CC: "Philippe Mathieu-Daudé" <philmd@redhat.com>
> Bug: https://bugs.gentoo.org/766743
> Bug: https://bugs.launchpad.net/qemu/+bug/1913012
> Patch-by: Jannik Glückert
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> ---
>   pc-bios/descriptors/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pc-bios/descriptors/meson.build b/pc-bios/descriptors/meson.build
> index ac6ec66b00..29efa16d99 100644
> --- a/pc-bios/descriptors/meson.build
> +++ b/pc-bios/descriptors/meson.build
> @@ -9,7 +9,7 @@ if install_edk2_blobs
>     ]
>       configure_file(input: files(f),
>                      output: f,
> -                   configuration: {'DATADIR': qemu_datadir},
> +                   configuration: {'DATADIR': get_option('prefix') / qemu_datadir},
>                      install: get_option('install_blobs'),
>                      install_dir: qemu_datadir / 'firmware')
>     endforeach
> 

Queued, thanks!

Paolo



      parent reply	other threads:[~2021-02-01  8:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210131143434.2513363-1-slyfox@gentoo.org>
2021-01-31 14:56 ` [PATCH] pc-bios/descriptors: fix paths in json files Philippe Mathieu-Daudé
2021-01-31 15:22   ` Jannik Glückert
2021-01-31 16:21     ` Philippe Mathieu-Daudé
2021-02-01  8:31 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2133b6f7-9128-a98c-66c8-72ef223d23f6@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=slyfox@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).