From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35455)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bGMJQ-0000wt-2V
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 04:18:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bGMJJ-0002X2-TN
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 04:18:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51016)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bGMJJ-0002Wd-OC
	for qemu-devel@nongnu.org; Fri, 24 Jun 2016 04:17:57 -0400
References: <1466698330-6021-1-git-send-email-armbru@redhat.com>
	<1466698330-6021-5-git-send-email-armbru@redhat.com>
	<CAFEAcA9Oz2hjQEM3m6y=uonC5KQkbin67=e5ZS+EeZC-Pd5Wyg@mail.gmail.com>
	<87oa6rxax1.fsf@dusky.pond.sub.org>
	<CAFEAcA8UUCBuZd==_NyjnoeFqg+jQ+6uyWSqNYO2d412F59jPw@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <213da4da-cc47-e0a2-c90d-dac2f8ca911f@redhat.com>
Date: Fri, 24 Jun 2016 10:17:54 +0200
MIME-Version: 1.0
In-Reply-To: <CAFEAcA8UUCBuZd==_NyjnoeFqg+jQ+6uyWSqNYO2d412F59jPw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC 4/5] include: Move typedef qemu_irq to
 qemu/typedefs.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Markus Armbruster <armbru@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>



On 24/06/2016 10:15, Peter Maydell wrote:
>>>> >>> @@ -31,6 +31,7 @@ typedef struct FWCfgState FWCfgState;
>>>> >>>  typedef struct HCIInfo HCIInfo;
>>>> >>>  typedef struct I2CBus I2CBus;
>>>> >>>  typedef struct I2SCodec I2SCodec;
>>>> >>> +typedef struct IRQState *qemu_irq;
>>>> >>>  typedef struct ISABus ISABus;
>>>> >>>  typedef struct ISADevice ISADevice;
>>>> >>>  typedef struct IsaDma IsaDma;
>>> >>
>>> >> Everything else in typedefs.h is a "typedef struct Thing Thing",
>>> >> but qemu_irq is different...
>> >
>> > We want to keep our readers on their toes!
> It would mean you now have to decide whether the file is orderd
> by the types being defined or by the underlying implementation
> type (previously both orders were the same)...

Indeed, and renaming the struct is trivial because it's used in a
handful of places only.

Paolo