From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 064A3C00A89 for ; Thu, 5 Nov 2020 12:36:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E3FEC2078E for ; Thu, 5 Nov 2020 12:36:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=crudebyte.com header.i=@crudebyte.com header.b="Che2Ca+e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3FEC2078E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=crudebyte.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaeUr-0002An-1P for qemu-devel@archiver.kernel.org; Thu, 05 Nov 2020 07:36:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaeNn-0001n5-PT; Thu, 05 Nov 2020 07:28:51 -0500 Received: from lizzy.crudebyte.com ([91.194.90.13]:39857) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaeNk-0004am-RZ; Thu, 05 Nov 2020 07:28:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=lizzy; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Content-ID:Content-Description; bh=YPq/3yfFXLfPvAw4wtoOounGC9mB9vXYDsxqJBUvGTo=; b=Che2Ca+e11VJP8CmIRlpunNLMr qRQYJY4aEOG0sW7s1/7HUUp1XpWOrnMQhEb929HTWWJVhd+a4HkpskarxDIq0Mx5NJDMkLSzlv4VU yFcXwTsWK9Zs1Mj3kZL1g8mRojrX7WB/Uy3pxPoLLQGo/c55dsUS2KFv/49dHaSDSc5JNGbkRljuE qAnqlj3I9P12l8yLegvSKpZyeBET7x7v9yXLWzM3e8xfxSyep95AX6+4VfUDDJoCdPoah94WEtGnQ Olx7AccVhzmuG0AHKIG/Nk/isz/Zgy/ZfRPtwS4tbj5DgBKVrZ9xU6aBL0JTHG3q1xebPNdtoNHOe kF4G/s6Q==; From: Christian Schoenebeck To: Greg Kurz Cc: Philippe =?ISO-8859-1?Q?Mathieu=2DDaud=E9?= , qemu-devel@nongnu.org, Fam Zheng , Thomas Huth , Stefano Stabellini , "Daniel P . Berrange" , Matthew Rosato , David Hildenbrand , Alex =?ISO-8859-1?Q?Benn=E9e?= , Cornelia Huck , Wainer dos Santos Moschetta , Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org, xen-devel@lists.xenproject.org, Anthony Perard , Paolo Bonzini , Paul Durrant , Richard Henderson Subject: Re: [PATCH-for-5.2 v3 2/4] hw/9pfs: Fix Kconfig dependency problem between 9pfs and Xen Date: Thu, 05 Nov 2020 13:28:31 +0100 Message-ID: <2140852.vo20GZeEQY@silver> In-Reply-To: <20201105132346.5e0adf94@bahia.lan> References: <20201104115706.3101190-1-philmd@redhat.com> <17370310-d69c-91ff-763d-52a1355ad605@redhat.com> <20201105132346.5e0adf94@bahia.lan> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Received-SPF: pass client-ip=91.194.90.13; envelope-from=qemu_oss@crudebyte.com; helo=lizzy.crudebyte.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/05 07:28:44 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Donnerstag, 5. November 2020 13:23:46 CET Greg Kurz wrote: > On Thu, 5 Nov 2020 13:15:59 +0100 >=20 > Philippe Mathieu-Daud=E9 wrote: > > On 11/4/20 6:54 PM, Greg Kurz wrote: > > > On Wed, 04 Nov 2020 13:18:09 +0100 > > >=20 > > > Christian Schoenebeck wrote: > > >> On Mittwoch, 4. November 2020 12:57:04 CET Philippe Mathieu-Daud=E9= =20 wrote: > > >>> Commit b2c00bce54c ("meson: convert hw/9pfs, cleanup") introduced > > >>> CONFIG_9PFS (probably a wrong conflict resolution). This config is > > >>> not used anywhere. Backends depend on CONFIG_FSDEV_9P which itself > > >>> depends on CONFIG_VIRTFS. > > >>>=20 > > >>> Remove the invalid CONFIG_9PFS and use CONFIG_FSDEV_9P instead, to > > >>>=20 > > >>> fix the './configure --without-default-devices --enable-xen' build: > > >>> /usr/bin/ld: libcommon.fa.p/hw_xen_xen-legacy-backend.c.o: in > > >>> function > > >>>=20 > > >>> `xen_be_register_common': hw/xen/xen-legacy-backend.c:754: undefined > > >>> reference to `xen_9pfs_ops' /usr/bin/ld: > > >>> libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x8): undefined > > >>> reference to > > >>> `local_ops' /usr/bin/ld: > > >>> libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x20): undefined > > >>> reference > > >>> to `synth_ops' /usr/bin/ld: > > >>> libcommon.fa.p/fsdev_qemu-fsdev.c.o:(.data.rel+0x38): undefined > > >>> reference > > >>> to `proxy_ops' collect2: error: ld returned 1 exit status > > >>>=20 > > >>> Fixes: b2c00bce54c ("meson: convert hw/9pfs, cleanup") > > >>> Suggested-by: Paolo Bonzini > > >>> Acked-by: Greg Kurz > > >>> Tested-by: Greg Kurz > > >>> Signed-off-by: Philippe Mathieu-Daud=E9 > > >>=20 > > >> Acked-by: Christian Schoenebeck > > >=20 > > > Phil, > > >=20 > > > Same questioning as Connie. Do you intend to get this merged or should > > > Christian or I take care of that ? > >=20 > > Same answer too =3D) If you are preparing a pull request, please go ahe= ad! >=20 > Heh I've just seen your answer. >=20 > Christian, >=20 > Maybe you can add this patch in your next PR ? Yes, I will prepare a 9p PR today anyway, so I will include this patch. Best regards, Christian Schoenebeck