From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5Gp7-0002HI-74 for qemu-devel@nongnu.org; Tue, 24 May 2016 14:12:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5Gp6-000614-Bc for qemu-devel@nongnu.org; Tue, 24 May 2016 14:12:57 -0400 References: <1463470536-8981-1-git-send-email-famz@redhat.com> <1463470536-8981-17-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <2141007a-c910-cc64-0a09-6375a6b044a8@redhat.com> Date: Tue, 24 May 2016 20:12:45 +0200 MIME-Version: 1.0 In-Reply-To: <1463470536-8981-17-git-send-email-famz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5418DqJ0x4aaN9e3K20eEGahF3DLIAeoa" Subject: Re: [Qemu-devel] [PATCH v5 16/27] qemu-nbd: Add "--no-lock/-L" option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , Markus Armbruster , Eric Blake , John Snow , qemu-block@nongnu.org, berrange@redhat.com, pbonzini@redhat.com, den@openvz.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5418DqJ0x4aaN9e3K20eEGahF3DLIAeoa From: Max Reitz To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , Markus Armbruster , Eric Blake , John Snow , qemu-block@nongnu.org, berrange@redhat.com, pbonzini@redhat.com, den@openvz.org, stefanha@redhat.com Message-ID: <2141007a-c910-cc64-0a09-6375a6b044a8@redhat.com> Subject: Re: [PATCH v5 16/27] qemu-nbd: Add "--no-lock/-L" option References: <1463470536-8981-1-git-send-email-famz@redhat.com> <1463470536-8981-17-git-send-email-famz@redhat.com> In-Reply-To: <1463470536-8981-17-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 17.05.2016 09:35, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > qemu-nbd.c | 7 ++++++- > qemu-nbd.texi | 2 ++ > 2 files changed, 8 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz Random interjection: You've described -L as "disable image locking", but as "disables image locking" in the previous patch and as "disable image lock" in patch 13. Maybe you should settle for a single expression. :-) Max --5418DqJ0x4aaN9e3K20eEGahF3DLIAeoa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXRJmdAAoJEDuxQgLoOKytGcIH/15dKseDaToMM5dEKr+SJkfz WItlJYML1JwWXXVTu0Xl1qwEilSakO17aheqsO59jADODQTg2t2DPgb9IBaPP+fx TogFw+UDKOKm8fZ5YKu1kKyRR+1aLZXAWhUbaF7KijHsb+1yTwHvr8dRhWc1RAbv gTWqpQEH99TmOxe4tLrqBtE7B37HFy8l+IYK+Lbn8reimWOvDaUqiy1S25BnB6Km ENPHa4ORn8t2ixJX60cSUriFE0QzDMjXstz9V2Nt6GpewEn8lGYsj+AUh6M1AJCa krhhY6Ved7BnMufjXRo8Fypf0+ltQvSk8mpDAwLUE12nNqMAEnwYTsN0Q/z/rm0= =/+oo -----END PGP SIGNATURE----- --5418DqJ0x4aaN9e3K20eEGahF3DLIAeoa--