* [PATCH] remote: Remove unused remote_iohub_finalize
@ 2024-09-19 16:58 dave
2024-09-19 17:07 ` Jag Raman
2024-10-02 10:41 ` Thomas Huth
0 siblings, 2 replies; 3+ messages in thread
From: dave @ 2024-09-19 16:58 UTC (permalink / raw)
To: elena.ufimtseva, jag.raman, qemu-devel; +Cc: Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <dave@treblig.org>
remote_iohub_finalize has never been used.
Remove it.
Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
---
hw/remote/iohub.c | 13 -------------
include/hw/remote/iohub.h | 1 -
2 files changed, 14 deletions(-)
diff --git a/hw/remote/iohub.c b/hw/remote/iohub.c
index 40dfee4bad..988d3285cc 100644
--- a/hw/remote/iohub.c
+++ b/hw/remote/iohub.c
@@ -33,19 +33,6 @@ void remote_iohub_init(RemoteIOHubState *iohub)
}
}
-void remote_iohub_finalize(RemoteIOHubState *iohub)
-{
- int pirq;
-
- for (pirq = 0; pirq < REMOTE_IOHUB_NB_PIRQS; pirq++) {
- qemu_set_fd_handler(event_notifier_get_fd(&iohub->resamplefds[pirq]),
- NULL, NULL, NULL);
- event_notifier_cleanup(&iohub->irqfds[pirq]);
- event_notifier_cleanup(&iohub->resamplefds[pirq]);
- qemu_mutex_destroy(&iohub->irq_level_lock[pirq]);
- }
-}
-
int remote_iohub_map_irq(PCIDevice *pci_dev, int intx)
{
return pci_dev->devfn;
diff --git a/include/hw/remote/iohub.h b/include/hw/remote/iohub.h
index 6a8444f9a9..09ee6c77b6 100644
--- a/include/hw/remote/iohub.h
+++ b/include/hw/remote/iohub.h
@@ -37,6 +37,5 @@ void remote_iohub_set_irq(void *opaque, int pirq, int level);
void process_set_irqfd_msg(PCIDevice *pci_dev, MPQemuMsg *msg);
void remote_iohub_init(RemoteIOHubState *iohub);
-void remote_iohub_finalize(RemoteIOHubState *iohub);
#endif
--
2.46.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] remote: Remove unused remote_iohub_finalize
2024-09-19 16:58 [PATCH] remote: Remove unused remote_iohub_finalize dave
@ 2024-09-19 17:07 ` Jag Raman
2024-10-02 10:41 ` Thomas Huth
1 sibling, 0 replies; 3+ messages in thread
From: Jag Raman @ 2024-09-19 17:07 UTC (permalink / raw)
To: dave@treblig.org; +Cc: Elena Ufimtseva, qemu-devel@nongnu.org
> On Sep 19, 2024, at 12:59 PM, dave@treblig.org wrote:
>
> From: "Dr. David Alan Gilbert" <dave@treblig.org>
>
> remote_iohub_finalize has never been used.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
Reviewed-by: Jagannathan Raman <jag.raman@oracle.com>
Thanks, Dave!
> ---
> hw/remote/iohub.c | 13 -------------
> include/hw/remote/iohub.h | 1 -
> 2 files changed, 14 deletions(-)
>
> diff --git a/hw/remote/iohub.c b/hw/remote/iohub.c
> index 40dfee4bad..988d3285cc 100644
> --- a/hw/remote/iohub.c
> +++ b/hw/remote/iohub.c
> @@ -33,19 +33,6 @@ void remote_iohub_init(RemoteIOHubState *iohub)
> }
> }
>
> -void remote_iohub_finalize(RemoteIOHubState *iohub)
> -{
> - int pirq;
> -
> - for (pirq = 0; pirq < REMOTE_IOHUB_NB_PIRQS; pirq++) {
> - qemu_set_fd_handler(event_notifier_get_fd(&iohub->resamplefds[pirq]),
> - NULL, NULL, NULL);
> - event_notifier_cleanup(&iohub->irqfds[pirq]);
> - event_notifier_cleanup(&iohub->resamplefds[pirq]);
> - qemu_mutex_destroy(&iohub->irq_level_lock[pirq]);
> - }
> -}
> -
> int remote_iohub_map_irq(PCIDevice *pci_dev, int intx)
> {
> return pci_dev->devfn;
> diff --git a/include/hw/remote/iohub.h b/include/hw/remote/iohub.h
> index 6a8444f9a9..09ee6c77b6 100644
> --- a/include/hw/remote/iohub.h
> +++ b/include/hw/remote/iohub.h
> @@ -37,6 +37,5 @@ void remote_iohub_set_irq(void *opaque, int pirq, int level);
> void process_set_irqfd_msg(PCIDevice *pci_dev, MPQemuMsg *msg);
>
> void remote_iohub_init(RemoteIOHubState *iohub);
> -void remote_iohub_finalize(RemoteIOHubState *iohub);
>
> #endif
> --
> 2.46.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] remote: Remove unused remote_iohub_finalize
2024-09-19 16:58 [PATCH] remote: Remove unused remote_iohub_finalize dave
2024-09-19 17:07 ` Jag Raman
@ 2024-10-02 10:41 ` Thomas Huth
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2024-10-02 10:41 UTC (permalink / raw)
To: dave, elena.ufimtseva, jag.raman, qemu-devel, QEMU Trivial
On 19/09/2024 18.58, dave@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <dave@treblig.org>
>
> remote_iohub_finalize has never been used.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> ---
> hw/remote/iohub.c | 13 -------------
> include/hw/remote/iohub.h | 1 -
> 2 files changed, 14 deletions(-)
>
> diff --git a/hw/remote/iohub.c b/hw/remote/iohub.c
> index 40dfee4bad..988d3285cc 100644
> --- a/hw/remote/iohub.c
> +++ b/hw/remote/iohub.c
> @@ -33,19 +33,6 @@ void remote_iohub_init(RemoteIOHubState *iohub)
> }
> }
>
> -void remote_iohub_finalize(RemoteIOHubState *iohub)
> -{
> - int pirq;
> -
> - for (pirq = 0; pirq < REMOTE_IOHUB_NB_PIRQS; pirq++) {
> - qemu_set_fd_handler(event_notifier_get_fd(&iohub->resamplefds[pirq]),
> - NULL, NULL, NULL);
> - event_notifier_cleanup(&iohub->irqfds[pirq]);
> - event_notifier_cleanup(&iohub->resamplefds[pirq]);
> - qemu_mutex_destroy(&iohub->irq_level_lock[pirq]);
> - }
> -}
> -
> int remote_iohub_map_irq(PCIDevice *pci_dev, int intx)
> {
> return pci_dev->devfn;
> diff --git a/include/hw/remote/iohub.h b/include/hw/remote/iohub.h
> index 6a8444f9a9..09ee6c77b6 100644
> --- a/include/hw/remote/iohub.h
> +++ b/include/hw/remote/iohub.h
> @@ -37,6 +37,5 @@ void remote_iohub_set_irq(void *opaque, int pirq, int level);
> void process_set_irqfd_msg(PCIDevice *pci_dev, MPQemuMsg *msg);
>
> void remote_iohub_init(RemoteIOHubState *iohub);
> -void remote_iohub_finalize(RemoteIOHubState *iohub);
>
> #endif
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-02 10:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-19 16:58 [PATCH] remote: Remove unused remote_iohub_finalize dave
2024-09-19 17:07 ` Jag Raman
2024-10-02 10:41 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).