From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2cxf-0005V0-9F for qemu-devel@nongnu.org; Tue, 17 May 2016 07:14:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2cxY-0003uF-29 for qemu-devel@nongnu.org; Tue, 17 May 2016 07:14:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2cxX-0003uA-S6 for qemu-devel@nongnu.org; Tue, 17 May 2016 07:14:43 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 33F63619FA for ; Tue, 17 May 2016 11:14:43 +0000 (UTC) References: <1460384056-29494-1-git-send-email-stefanha@redhat.com> <573AFB7E.5000905@redhat.com> From: Max Reitz Message-ID: <214ef2a3-8d51-9570-1be5-fff12a58231a@redhat.com> Date: Tue, 17 May 2016 13:14:40 +0200 MIME-Version: 1.0 In-Reply-To: <573AFB7E.5000905@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="53Q1KRKTQUwnx3Q7pd3n5NsmgThdK9elI" Subject: Re: [Qemu-devel] [RFC for-2.7] block: keep AioContext pointer in BlockBackend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --53Q1KRKTQUwnx3Q7pd3n5NsmgThdK9elI From: Max Reitz To: Paolo Bonzini , Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf Message-ID: <214ef2a3-8d51-9570-1be5-fff12a58231a@redhat.com> Subject: Re: [RFC for-2.7] block: keep AioContext pointer in BlockBackend References: <1460384056-29494-1-git-send-email-stefanha@redhat.com> <573AFB7E.5000905@redhat.com> In-Reply-To: <573AFB7E.5000905@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 17.05.2016 13:07, Paolo Bonzini wrote: >=20 >=20 > On 17/05/2016 12:52, Max Reitz wrote: >> A trivial way to do this would be to query the BDS's AIO context in >> blk_get_aio_context() and update the BB's context if they don't match.= >> The more correct way would probably be to make bdrv_attach_aio_context= () >> update its BB's (or BBs', in the future) AIO context. >=20 > That could be another BdrvChild member, couldn't it? I think it would rather require a new function pointer in BdrvChildRole (after Kevin's series, that is). As a side effect, that would allow us to propagate the context even up the BDS tree, which we currently do not.= Max --53Q1KRKTQUwnx3Q7pd3n5NsmgThdK9elI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXOv0gAAoJEDuxQgLoOKyt2ZMH/3EnTLJBsDrXXwl3BPB17jRE IQB/JXF/pzj8FnFso1HC8LmwKJihSC6FqRjWBxgwNNGVdy5SbpDdMk7QMywqZr4k 10fiBofMCoFcapgNk/5JjAG+eeOMTlLfYrdZ78kAgDBycOrIUl6X92Lup9ITpPl/ uQKL/wChE2GYU0ksul+uwzCQLJ7YgF8vKGJaX5xTAhOOZgevSNXkuRABqo5eHUH8 DNRELEBArRpw3ZiVZ1BSM4Kk53SfapvARKjdBJf+l5YMBQOx3gKReLG2o2SVcSee GnnPhPkKgl7DZiJ5FpzE4C7BaG3Soy2sZ6WVs/1i92i+Akn8EqUsvGo9tFf26V8= =/nsy -----END PGP SIGNATURE----- --53Q1KRKTQUwnx3Q7pd3n5NsmgThdK9elI--