Re: [Qemu-devel] [PATCH 1/3] crypto: require gnutls >= 3.1.18 for building QEMU

[Eric Blake <eblake@redhat.com>]

On 07/18/2018 07:03 AM, Daniel P. Berrangé wrote:
> gnutls 3.0.0 was released in 2011 and all the distros that are build
> target platforms for QEMU [1] include it:
> 
>    RHEL-7: 3.1.18
>    Debian (Stretch): 3.5.8
>    Debian (Jessie): 3.3.8
>    OpenBSD (ports): 3.5.18
>    FreeBSD (ports): 3.5.18
>    OpenSUSE Leap 15: 3.6.2
>    Ubuntu (Xenial): 3.4.10
>    macOS (Homebrew): 3.5.19
> 
> Based on this, it is reasonable to require gnutls >= 3.1.18 in QEMU
> which allows for all conditional version checks in the code to be
> removed.

Looks reasonable.

> 
> [1] https://qemu.weilnetz.de/doc/qemu-doc.html#Supported-build-platforms
> 

Any chance we can get http builds of the docs hosted directly on 
qemu.org someday?  But unrelated to your patch.

> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> @@ -2675,79 +2674,28 @@ fi
>   ##########################################
>   # GNUTLS probe
>   
> -gnutls_works() {
> -    # Unfortunately some distros have bad pkg-config information for gnutls
> -    # such that it claims to exist but you get a compiler error if you try
> -    # to use the options returned by --libs. Specifically, Ubuntu for --static
> -    # builds doesn't work:
> -    # https://bugs.launchpad.net/ubuntu/+source/gnutls26/+bug/1478035

This bug is still in state NEW, but targets Ubuntu 14.04 and "Package: 
libgnutls-dev 2.12.23-12ubuntu2.2", so is probably indeed old enough 
that it is hopefully a non-issue for gnutls > 3 in the versions of 
Ubuntu we specifically support. However, I'm not enough of an Ubuntu 
user myself to confirm whether things still work, so you'll probably 
want to collect additional R-b or Tested-by before accepting this for 
qemu 3.1.

Everything else looks clean to me, so

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org