From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>, Julian Kirsch <git@kirschju.re>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] X86/HMP: Expose x86 model specific registers via human monitor
Date: Thu, 9 Mar 2017 17:32:08 +0100 [thread overview]
Message-ID: <21562465-f6db-e36c-3578-27b43ea9928b@redhat.com> (raw)
In-Reply-To: <20170308184426.GG4694@thinpad.lan.raisama.net>
On 08/03/2017 19:44, Eduardo Habkost wrote:
>>> If it's only supported by x86, I would just move the
>>> implementation to a x86-specific file, and add a stub for the
>>> other architectures. See qmp_query_gic_capabilities() for an
>>> example.
>>>
>>> Also, the command should be added to
>>> qmp_unregister_commands_hack() so we don't even report it as
>>> available on other architectures.
>>>
>> Awesome, thanks for your comments, I'll move the qmp commands to
>> target/i386/monitor.c and unregister them for architectures other than I386. Do
>> I have to explicitly take care of unregistering the hmp commands as well?
> For HMP commands, it looks like you can simply use #ifdefs inside
> hmp-commands.hx.
Do we need the QMP commands? There is no QMP version of info registers,
for example.
Paolo
next prev parent reply other threads:[~2017-03-09 16:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170308001637.9838-1-git@kirschju.re>
2017-03-08 2:36 ` [Qemu-devel] [PATCH] X86/HMP: Expose x86 model specific registers via human monitor Eric Blake
2017-03-08 8:26 ` Julian Kirsch
2017-03-10 14:09 ` Igor Mammedov
2017-03-10 16:11 ` Julian Kirsch
2017-03-08 3:09 ` Richard Henderson
2017-03-08 11:34 ` Julian Kirsch
2017-03-08 11:59 ` Dr. David Alan Gilbert
2017-03-08 13:57 ` Eduardo Habkost
2017-03-08 16:08 ` Julian Kirsch
2017-03-08 18:44 ` Eduardo Habkost
2017-03-09 16:32 ` Paolo Bonzini [this message]
2017-03-09 17:27 ` Eduardo Habkost
2017-03-09 18:05 ` Julian Kirsch
2017-03-08 15:40 ` Julian Kirsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21562465-f6db-e36c-3578-27b43ea9928b@redhat.com \
--to=pbonzini@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=git@kirschju.re \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).