From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47696)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pmoore@redhat.com>) id 1XmPpQ-00027e-5e
	for qemu-devel@nongnu.org; Thu, 06 Nov 2014 11:22:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pmoore@redhat.com>) id 1XmPpL-0007gM-Qd
	for qemu-devel@nongnu.org; Thu, 06 Nov 2014 11:22:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50843)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pmoore@redhat.com>) id 1XmPpL-0007g3-IC
	for qemu-devel@nongnu.org; Thu, 06 Nov 2014 11:22:27 -0500
From: Paul Moore <pmoore@redhat.com>
Date: Thu, 06 Nov 2014 11:22:16 -0500
Message-ID: <2160380.fdzADCfzWy@sifl>
In-Reply-To: <1415285358-7446-1-git-send-email-eduardo.otubo@profitbricks.com>
References: <1415285358-7446-1-git-send-email-eduardo.otubo@profitbricks.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [Qemu-devel] [PATCH] seccomp: change configure to avoid arm 32
	to break
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Otubo <eduardo.otubo@profitbricks.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, philipp.gesang@intra2net.com

On Thursday, November 06, 2014 03:49:18 PM Eduardo Otubo wrote:
> Right now seccomp is breaking the compilation of Qemu on armv7l due
> to libsecomp current lack of support for this arch. This problem is
> already fixed on libseccomp upstream but no release date for that is
> scheduled to far. This patch disables support for seccomp on armv7l
> temporarily until libseccomp does a new release. Then I'll remove the
> hack and update libseccomp dependency on configure script.
> 
> Related bug: https://bugs.launchpad.net/qemu/+bug/1363641
> 
> Signed-off-by: Eduardo Otubo <eduardo.otubo@profitbricks.com>
> ---
>  configure | 20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/configure b/configure
> index 2f17bf3..16fd7f5 100755
> --- a/configure
> +++ b/configure
> @@ -1823,15 +1823,17 @@ fi
>  # libseccomp check
> 
>  if test "$seccomp" != "no" ; then
> -    if $pkg_config --atleast-version=2.1.0 libseccomp; then
> -        libs_softmmu="$libs_softmmu `$pkg_config --libs libseccomp`"
> -        QEMU_CFLAGS="$QEMU_CFLAGS `$pkg_config --cflags libseccomp`"
> -	seccomp="yes"
> -    else
> -	if test "$seccomp" = "yes"; then
> -            feature_not_found "libseccomp" "Install libseccomp devel >=
> 2.1.0" -	fi
> -	seccomp="no"
> +    if test "$cpu" = "i386" || test "$cpu" = "x86_64"; then
> +        if $pkg_config --atleast-version=2.1.0 libseccomp; then
> +            libs_softmmu="$libs_softmmu `$pkg_config --libs libseccomp`"
> +            QEMU_CFLAGS="$QEMU_CFLAGS `$pkg_config --cflags libseccomp`"
> +            seccomp="yes"
> +        else
> +            if test "$seccomp" = "yes"; then
> +                feature_not_found "libseccomp" "Install libseccomp devel >=
> 2.1.0" +            fi
> +            seccomp="no"
> +        fi
>      fi
>  fi
>  ##########################################

Also, note the current release of libseccomp is v2.1.1 which has a number of 
bug fixes on top of v2.1.0.

-- 
paul moore
security and virtualization @ redhat