From: Ben Taylor <sol10x86@cox.net>
To: Paul Brook <paul@codesourcery.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] patch for supporting SMB on Solaris host
Date: Fri, 22 Dec 2006 19:06:24 -0500 [thread overview]
Message-ID: <21716908.1166832384260.JavaMail.root@eastrmwml07.mgt.cox.net> (raw)
---- Paul Brook <paul@codesourcery.com> wrote:
> On Friday 22 December 2006 21:29, Paul Brook wrote:
> > On Friday 22 December 2006 20:07, Ben Taylor wrote:
> > > Seeing as there is some working going on in the Solaris QEMU port again,
> > > here's a real short patch to support Samba working on a Solaris Host.
> > > +#ifdef __sun__
> > > + snprintf(smb_cmdline, sizeof(smb_cmdline), "/bin/env LC_ALL=C
> > > /usr/sfw/sbin/smbd -s %s",
> > > + smb_conf);
> > > +#else
> >
> > Why does this have anything to do with solaris?
>
> Sorry, I was unclear. The /usr/swf bif is obviously a Solaris hack, and I
> think this is a bad way of implementing this.
Well, I suppose I can write a configure hack to replace to definte the smbd
binary, which will take about 30 seconds, hoping you'll find that more
digestable.
> I don't see why the /bin/env LC_ALL bits have anything to do with Solaris.
Let me inject a little humor. I'm american and speak only one language. The
guy who did the patch is in germany and did it for a reason, though he never
explained to me.
In meantime, I will resubmit the patch without the /bin/env LC_ALL bits, hopefully
to your liking and if it breaks on Solaris for some other reason, I'll be able to
argue with you why it needs to be there.
next reply other threads:[~2006-12-23 0:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-23 0:06 Ben Taylor [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-12-23 13:17 [Qemu-devel] patch for supporting SMB on Solaris host Ben Taylor
2006-12-23 1:40 Ben Taylor
2006-12-23 1:40 Ben Taylor
2006-12-23 1:48 ` Lennert Buytenhek
2006-12-22 20:07 Ben Taylor
2006-12-22 21:29 ` Paul Brook
2006-12-22 21:32 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21716908.1166832384260.JavaMail.root@eastrmwml07.mgt.cox.net \
--to=sol10x86@cox.net \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).