From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B063CA1012 for ; Thu, 4 Sep 2025 07:49:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uu4hz-0007J7-JP; Thu, 04 Sep 2025 03:48:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uu4hq-0007Hj-27 for qemu-devel@nongnu.org; Thu, 04 Sep 2025 03:48:32 -0400 Received: from mail.loongson.cn ([114.242.206.163]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uu4hm-0002fB-OM for qemu-devel@nongnu.org; Thu, 04 Sep 2025 03:48:29 -0400 Received: from loongson.cn (unknown [10.20.42.62]) by gateway (Coremail) with SMTP id _____8AxP_BBRLlo3JIGAA--.13820S3; Thu, 04 Sep 2025 15:48:17 +0800 (CST) Received: from [10.20.42.62] (unknown [10.20.42.62]) by front1 (Coremail) with SMTP id qMiowJDxrcE9RLloPnd9AA--.44366S3; Thu, 04 Sep 2025 15:48:16 +0800 (CST) Subject: Re: [PATCH v3 06/12] target/loongarch: Add tlb search callback in loongarch_tlb_search() To: Richard Henderson , Song Gao , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Cc: Jiaxun Yang , qemu-devel@nongnu.org References: <20250903084827.3085911-1-maobibo@loongson.cn> <20250903084827.3085911-7-maobibo@loongson.cn> <58318cbc-05fe-4de5-bc1a-f68bfb30ebaf@linaro.org> From: Bibo Mao Message-ID: <21849d27-fba7-b121-f31e-dbfb113c8412@loongson.cn> Date: Thu, 4 Sep 2025 15:46:13 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <58318cbc-05fe-4de5-bc1a-f68bfb30ebaf@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CM-TRANSID: qMiowJDxrcE9RLloPnd9AA--.44366S3 X-CM-SenderInfo: xpdruxter6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBj93XoWxJr4UXF1xJw4rWr4DCrykJFc_yoW8GrW5pr 97CrWUKF4UJFn3J3sagw15ZFn8Zr4kJa1jqFnav34rCrnxJwnFqr4vqw4v9Fy8Xa1xXF1j qr4Fvr1xZFW7X3cCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUvYb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1l5I 8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AK xVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07AlzV AYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E 14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIx kGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAF wI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F 4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07jOF4_U UUUU= Received-SPF: pass client-ip=114.242.206.163; envelope-from=maobibo@loongson.cn; helo=mail.loongson.cn X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-1.65, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2025/9/3 下午9:14, Richard Henderson wrote: > On 9/3/25 10:48, Bibo Mao wrote: >> With function loongarch_tlb_search(), it is to search TLB entry with >> speficied virtual address, the difference is selection with asid and >> global bit. Here add selection callback with asid and global bit. >> >> Signed-off-by: Bibo Mao >> --- >>   target/loongarch/tcg/tlb_helper.c | 19 ++++++++++++++++--- >>   1 file changed, 16 insertions(+), 3 deletions(-) >> >> diff --git a/target/loongarch/tcg/tlb_helper.c >> b/target/loongarch/tcg/tlb_helper.c >> index 00422f259d..006fe1b207 100644 >> --- a/target/loongarch/tcg/tlb_helper.c >> +++ b/target/loongarch/tcg/tlb_helper.c >> @@ -21,6 +21,17 @@ >>   #include "cpu-csr.h" >>   #include "tcg/tcg_loongarch.h" >> +typedef bool (*tlb_match)(int global, int asid, int tlb_asid); > > Should global parameter be bool? Will do. > >> + >> +static bool tlb_match_any(int global, int asid, int tlb_asid) >> +{ >> +    if (global == 1 || tlb_asid == asid) { >> +        return true; >> +    } >> + >> +    return false; >> +} > > More compact as > >     return global || tlb_asid == asid; yes, this is better. Will do in next version. Regards Bibo Mao > > Otherwise, > Reviewed-by: Richard Henderson > > > r~