From: Richard Henderson <richard.henderson@linaro.org>
To: Helge Deller <deller@gmx.de>, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Laurent Vivier" <laurent@vivier.eu>
Subject: Re: [PATCH] linux-user/strace: Add missing signal strings
Date: Tue, 19 Nov 2019 21:17:54 +0100 [thread overview]
Message-ID: <21861bfc-f656-0f77-f29d-1dbaabfdaefc@linaro.org> (raw)
In-Reply-To: <06aaa584-fc97-8097-ca52-00d97982e5be@gmx.de>
On 11/19/19 9:06 PM, Helge Deller wrote:
>>> +#ifdef SIGSTKFLT
>>> + case TARGET_SIGSTKFLT: signal_name = "SIGSTKFLT"; break;
>>> +#endif
>>
>> Wrong ifdef.
>
> Same here, see in linux-user/signal.c (line 50):
> #ifdef SIGSTKFLT
> [SIGSTKFLT] = TARGET_SIGSTKFLT,
> #endif
But that one actually references SIGSTKFLT, but the case above does not.
You probably don't need the ifdef at all.
r~
prev parent reply other threads:[~2019-11-19 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 18:51 [PATCH] linux-user/strace: Add missing signal strings Helge Deller
2019-11-19 19:56 ` Richard Henderson
2019-11-19 20:06 ` Helge Deller
2019-11-19 20:10 ` Helge Deller
2019-11-19 20:17 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21861bfc-f656-0f77-f29d-1dbaabfdaefc@linaro.org \
--to=richard.henderson@linaro.org \
--cc=deller@gmx.de \
--cc=f4bug@amsat.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).