Re: [PATCH v2 2/2] pci: add romsize property

[Paolo Bonzini <pbonzini@redhat.com>]

On 29/01/21 21:06, BALATON Zoltan wrote:
>> The empty property value configures the device not to have a ROM file 
>> at all. The commit message says that ROM files (if they exist) cannot 
>> be empty, corresponding to this code in pci_add_option_rom:
>>
>>    } else if (size == 0) {
>>        error_setg(errp, "romfile \"%s\" is empty", pdev->romfile);
>>        g_free(path);
>>        return;
>>    }
> 
> OK, then it was just not clear to me that the commit message talks about 
> the romfile itself and not the property.
> 
> By the way, does it make sense to compare uint32_t value to -1 and could 
> that provoke some compiler/sanitiser warnings? Is it better to have a 
> signed type or use UINT32_MAX or simlar instead?

There is probably some warning for it but I think not even -Wextra 
enables it by default.

Paolo